This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Use a stricter import order #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
approved these changes
Oct 25, 2018
lemonmade
approved these changes
Oct 25, 2018
Force the order to be builtin, external, internal, parent, sibling instead of allowing intermingling.
BPScott
force-pushed
the
stricter-import-order
branch
from
ba7f7a6 to
1196748
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we talked about ordering imports in #web-foundation-tech.
General opinion was alphabetic ordering is annoying but grouping types of imports - node buildins, vs npm modules vs relative paths etc - would be handy as we already aim to do that anyway.
This updates our import/order rule to be a bit stricter around forcing ordering based upon the type of import to the order goes internal imports (
components/Blah) then parents (../Blah) then siblings (./Blah) instead of allowing those to be intermingled.No ordering inside those groups is enforced, which shall keep the "no alphabets" group happy. And yes this has an autofix.
See https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md for more info