This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
restoring prettier parser override in the typescript-prettier config #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
This restores code that was deleted in https://github.com/Shopify/eslint-plugin-shopify/pull/170/files#diff-56a2d129bcbecca23453c869c1300973L7
This revert is the easiest path to reclaim old behaviour.
@patsissons and I have been pairing on this today and we have a better, more long-term fix for this based upon investigation. Pat shall put that up, with a bunch of regression tests once this is merged.
GoodForOneFare
approved these changes
Sep 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with
prettierplugin using the incorrect parser when thegraphqlplugin is also enabled.