adding eslint-plugin-graphql as dependency

[patsissons]

relates to https://github.com/Shopify/sewing-kit/issues/971 and https://github.com/Shopify/web/pull/6689

This plugin is used by sewing-kit. Rather than having sewing kit depend on both this plugin and eslint-plugin-shopify, we can instead shuffle eslint-plugin-graphql as a dependency of this plugin and pull in all plugins from a single dependency requirement.

[lemonmade]

Presumably we'd want to expose a config for GraphQL that just passes a bunch of stuff through to the ESLint plugin rules?

[patsissons]

the base graphql config for the plugin (as per the online docs)

module.exports = {
  parser: 'babel-eslint',
  rules: {
    "graphql/template-strings": ['error', {
      env: 'literal'
    }]
  },
  plugins: [
    'graphql'
  ]
}

[lemonmade]

Oh right, it doesn't even need schema info. We can probably just have a new config for graphql that does this.

[patsissons]

on it! just updating the test

[patsissons]

@lemonmade should this be added to the all config?

[lemonmade]

I think so, IIRC all is used for detecting missing configuration for rules

[patsissons]

how does that work if the rule from the config is not exposed (like the jquery config)

[patsissons]

In order to test the all config, we need to add a graphql@^0.13.0 devDependency (a requirement of eslint-plugin-graphql) and supply a dummy .graphqlconfig.yml and schema.graphql file to enable the plugin to full initialize. Unfortunately, the plugin is not smart enough to bail out gracefully if it is included but no graphql configuration exists.

[GoodForOneFare]

eslint-plugin-graphql declares a peerDependency on graphql. Isn't that enough?

[patsissons]

i guess we only need it for testing, i can relegate to a dev dep.

[GoodForOneFare]

Makes sense, ty 👍

[GoodForOneFare]

Very much appreciated 👍 Thank you for pulling on this thread, then following through so quickly.