Revert "Fix hook strict return on undefined retuns (#251)"

This reverts commit a94bed7.
Shopify · Apr 27, 2019 · 3f5bdb0 · 3f5bdb0
1 parent a94bed7
commit 3f5bdb0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/lib/rules/react-hooks-strict-return.js b/lib/rules/react-hooks-strict-return.js
@@ -72,13 +72,9 @@ module.exports = {
 };
 
 function exceedsMaxReturnProperties(node, scope, max) {
-  const {argument} = node;
-
-  if (argument === null) {
-    return false;
-  }
-
-  const {type, elements} = argument;
+  const {
+    argument: {type, elements},
+  } = node;
 
   if (type !== 'ArrayExpression') {
     return getProps(node, scope).length > max;

diff --git a/tests/lib/rules/react-hooks-strict-return.js b/tests/lib/rules/react-hooks-strict-return.js
@@ -145,16 +145,6 @@ ruleTester.run('react-hooks-strict-return', rule, {
       }`,
       parser,
     },
-    {
-      code: `function useHookWithNoReturn() {}`,
-      parser,
-    },
-    {
-      code: `function useHookUndefinedReturn() {
-        return;
-      }`,
-      parser,
-    },
   ],
   invalid: [
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -145,16 +145,6 @@ ruleTester.run('react-hooks-strict-return', rule, { @@
           }`,
           parser,
         },
-        {
-          code: `function useHookWithNoReturn() {}`,
-          parser,
-        },
-        {
-          code: `function useHookUndefinedReturn() {
-            return;
-          }`,
-          parser,
-        },
       ],
       invalid: [
         {
@@ Expand Down @@