Add InstanceVariable linter #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the InstanceVariable linter, which can be limited to partials only (thus deprecating PartialInstanceVariable), but considers an instance variable in any template to be an offense by default. Also changed range behavior in both linters to highlight the instance variables themselves. The previous behavior highlighted the start of the variable to the end of the file. Finally, added support for detecting class instance variables.
| include LinterRegistry | ||
|
|
||
| class ConfigSchema < LinterConfig | ||
| property :partials_only, accepts: [true, false], default: false, reader: :partials_only? |
There was a problem hiding this comment.
Suggested change
| property :partials_only, accepts: [true, false], default: false, reader: :partials_only? | |
| property :partials_only, accepts: [true, false], default: true, reader: :partials_only? |
Instance variables in templates is the Rails default and those linters should follow Rails defaults.
emilong
force-pushed
the
instance-everywhere
branch
from
422a839
to
5d1dcb0
Compare
emilong
force-pushed
the
instance-everywhere
branch
from
5d1dcb0
to
422a839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the InstanceVariable linter, which can be limited to partials only
(thus deprecating PartialInstanceVariable), but considers an instance
variable in any template to be an offense by default.
Also changed range behavior in both linters to highlight the instance
variables themselves. The previous behavior highlighted the start of the
variable to the end of the file.
Finally, added support for detecting class instance variables.
Resolves #240