Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use alpha components #116

Merged
merged 13 commits into from
Aug 30, 2023
Merged

refactor: use alpha components #116

merged 13 commits into from
Aug 30, 2023

Conversation

devisscher
Copy link
Contributor

@devisscher devisscher commented Aug 30, 2023

Description

Fixes: #67

Removing the use of legacy components in the CombinationCard and adding a Box around components to help with layouts.

Updates:

Component Before After
DiscountPagePattern image image

Tophat

  1. run yarn storybook
  2. Ensure components are rendered properly and look the same or better than before 😄

@devisscher devisscher requested review from mathiusj and aeperea August 30, 2023 14:34
@github-actions
Copy link
Contributor

Hello and thank you for your contribution! Before we can merge your pull request, we ask that you create a changeset to describe your changes. This will help us manage versions and release notes. You can create a changeset by running yarn changeset in your terminal. You can find more information about our contribution guidelines here. Thank you again!

@devisscher devisscher changed the title refactor: use alpha components in combination card refactor: use alpha components Aug 30, 2023
Copy link
Contributor

@mathiusj mathiusj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM! 🎩

@devisscher devisscher merged commit 96f84c8 into main Aug 30, 2023
@devisscher devisscher deleted the combination-card-components branch August 30, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update to Alpha components
2 participants