Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use param_name instead of label to construct an id for filter values #839

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Use param_name instead of label to construct an id for filter values #839

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2e5dc4
Use param_name instead of label to construct an id for filter values
carolineschnapp Oct 29, 2021
a5d2d06
Fix for mobile drawer
carolineschnapp Nov 17, 2021
516da34
Merge branch 'main' into fix-id-of-filter-checkboxes
ludoboludo Jul 27, 2022
5bd9ce3
re add the original changes where necessary
ludoboludo Jul 27, 2022
644d043
fix duplicate ID
ludoboludo Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions snippets/facets.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
assign total_active_values = 0
if results.url
assign results_url = results.url
else
else
assign terms = results.terms | escape
assign results_url = '?q=' | append: terms | append: '&options%5Bprefix%5D=last&sort_by=' | append: sort_by
endif
Expand Down Expand Up @@ -62,11 +62,11 @@
<ul class="facets__list list-unstyled" role="list">
{%- for value in filter.values -%}
<li class="list-menu__item facets__item">
<label for="Filter-{{ filter.label | escape }}-{{ forloop.index }}" class="facet-checkbox{% if value.count == 0 and value.active == false %} facet-checkbox--disabled{% endif %}">
<label for="Filter-{{ filter.param_name | escape }}-{{ forloop.index }}" class="facet-checkbox{% if value.count == 0 and value.active == false %} facet-checkbox--disabled{% endif %}">
<input type="checkbox"
name="{{ value.param_name }}"
value="{{ value.value }}"
id="Filter-{{ filter.label | escape }}-{{ forloop.index }}"
id="Filter-{{ filter.param_name | escape }}-{{ forloop.index }}"
{% if value.active %}checked{% endif %}
{% if value.count == 0 and value.active == false %}disabled{% endif %}
>
Expand Down Expand Up @@ -245,7 +245,7 @@
<circle class="path" fill="none" stroke-width="6" cx="33" cy="33" r="30"></circle>
</svg>
</div>
</div>
</div>
</form>
</facet-filters-form>
{%- endunless -%}
Expand Down Expand Up @@ -299,7 +299,7 @@
<details id="Details-Mobile-{{ forloop.index }}-{{ section.id }}" class="mobile-facets__details js-filter" data-index="mobile-{{ forloop.index }}">
<summary class="mobile-facets__summary focus-inset">
<div>
<span>{{ filter.label | escape }}</span>
<span>{{ filter.label | escape }}</span>
<span class="mobile-facets__arrow no-js-hidden">{% render 'icon-arrow' %}</span>
<noscript>{% render 'icon-caret' %}</noscript>
</div>
Expand Down Expand Up @@ -446,7 +446,7 @@
{%- if results.terms -%}
<input type="hidden" name="q" value="{{ results.terms | escape }}">
<input name="options[prefix]" type="hidden" value="last">
{%- endif -%}
{%- endif -%}
</div>
</form>
</facet-filters-form>
Expand Down Expand Up @@ -505,4 +505,4 @@
</svg>
</div>
</div>
</div>
</div>