Fix some shopify theme check variable name formats
#3745
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've signed the CLA |
Bradley-Cooley
force-pushed
the
fix/theme-check-variable-names
branch
from
b9c272f to
17b4758
Compare
fl4viooliveira
added a commit
to sollab-io/knights
that referenced
this pull request
Mar 20, 2025
- Added auto-generated file header to multiple JSON and Liquid files to indicate that changes may be overwritten. - Introduced a new 'Header GFA' section in header-gfa.liquid with customizable logo, menu, and sticky header options. - Updated various templates to include empty settings objects for consistency and future customization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Fix
shopify theme checkwarnings due to variable names by renaming variables.Why are these changes introduced?
Reduce
shopify theme checkwarning count.What approach did you take?
Rename variables to match schema.
Other considerations
Decision log
Visual impact on existing themes
N/A
Testing steps/scenarios
shopify theme checkran with reduced warning count.Demo links
Checklist