Move initializer outside of performance callback #3736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Fix JS error when updating cart quantity
Why are these changes introduced?
Updating line item quantity in cart was causing a JS error. Source of the problem was ultimately that we were referencing a variable outside of it's defined scope.
Demo: https://screenshot.click/28-50-m3p8k-e1xpf.mp4
What approach did you take?
Confirmed that perf measurement doesn't need to include JSON parsing, moved the initializer to the parent scope
Demo links
Checklist