Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move initializer outside of performance callback #3736

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

lhoffbeck
Copy link
Contributor

PR Summary:

Fix JS error when updating cart quantity

Why are these changes introduced?

Updating line item quantity in cart was causing a JS error. Source of the problem was ultimately that we were referencing a variable outside of it's defined scope.

Demo: https://screenshot.click/28-50-m3p8k-e1xpf.mp4

What approach did you take?

Confirmed that perf measurement doesn't need to include JSON parsing, moved the initializer to the parent scope

Demo links

Checklist

@lhoffbeck lhoffbeck requested review from haeky and LA1CH3 February 28, 2025 15:53
@lhoffbeck lhoffbeck merged commit ecb06c3 into main Feb 28, 2025
8 checks passed
@lhoffbeck lhoffbeck deleted the fix-undefined-variable-issue branch February 28, 2025 16:01
NathanScheele pushed a commit to Misha-Puff/dawn that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants