Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No follow for Account Login header url #3611

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

jclarkin
Copy link
Contributor

@jclarkin jclarkin commented Sep 12, 2024

PR Summary:

Added nofollow to account login anchor-links in header.

Why are these changes introduced?

Shopify's merchant shop links currently lack a "nofollow" directive. Without this directive, Google may interpret these links as spammy backlinking.

More analysis details available here.

What approach did you take?

Implemented a "nofollow" directive on all merchant shop links pointing to shopify.com/account.

Visual impact on existing themes

None

Testing steps/scenarios

  • Review for valid HTML syntax.

Demo links

Can be tested locally via:

shopify theme dev --store=<your store url>

Checklist

@jclarkin jclarkin self-assigned this Sep 12, 2024
@jclarkin jclarkin marked this pull request as ready for review September 12, 2024 20:38
Copy link

@mjn mjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't 🎩 , but HTML changes are valid and accomplish the goal stated in the PR.

@jclarkin jclarkin requested review from a team and removed request for kmeleta September 17, 2024 13:28
@jclarkin jclarkin added the #gsd:42014 Merchant SEO label Sep 17, 2024
@jclarkin jclarkin merged commit dcecbbf into main Sep 18, 2024
8 checks passed
@jclarkin jclarkin deleted the growth_labs/update_account_login_link_to_be_no_follow branch September 18, 2024 19:59
dgopsq added a commit to unicomultiplo/dawn that referenced this pull request Sep 20, 2024
* Update 2 translation files (Shopify#3602)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Release 15.1.0 (Shopify#3595)

* Release notes + version bump

* Fixed arrow in announcement bar and caret in product variant dropdown

* Fixed announcement bar with multiple blocks

* Adjustment to variant picker caret

* Fixed multicolumn and mega menu

* Updated release note

* Fixed modals sticking around for Featured Product whens section is removed in the editor (Shopify#3609)

* No follow for Account Login header url (Shopify#3611)

* Update translations: merchant (Shopify#3612)

* Update 1 translation file

* Update 3 translation files

* Update 1 translation file

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix workflows

* Apply current custom theme

* Update `theme_name`

* Recent update

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

* Update from Shopify for theme dawn/main

Committed from shop: Unico & Multiplo

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Tyler Alsbury <60230011+tyleralsbury@users.noreply.github.com>
Co-authored-by: Jonathan Clarkin <jclarkin@users.noreply.github.com>
Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
NikoBerger pushed a commit to NikoBerger/palmafits-dawn that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:42014 Merchant SEO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants