Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify product-media-gallery snippet and consumers #3233

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Simplify product-media-gallery snippet and consumers #3233

merged 7 commits into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. Simplify featured product to use the same media gallery snippet as ma… 

    …in-product, simplify product-media-gallery, simplify main-product

Updated CSS to fix overflow issue on mobile browsers
    @lhoffbeck
    lhoffbeck committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e3343d7 View commit details
    Browse the repository at this point in the history

  2. Set images with the network response instead of by rendering hidden i… 

    …mages
    @lhoffbeck
    lhoffbeck committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f421978 View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary assignment

    @lhoffbeck
    lhoffbeck committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ce6ddd7 View commit details
    Browse the repository at this point in the history

  4. Update media refresh handling to minimize rerenders

    @lhoffbeck
    lhoffbeck committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ce60a3d View commit details
    Browse the repository at this point in the history

  5. Tweaks to fix JS error and modal content not updating when switching … 

    …away from a variant with a featured image
    @lhoffbeck
    lhoffbeck committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    06b57af View commit details
    Browse the repository at this point in the history

  6. Removed dead code

    @lhoffbeck
    lhoffbeck committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    300b6fb View commit details
    Browse the repository at this point in the history

  7. Update fallback selector

    @lhoffbeck
    lhoffbeck committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5abaa7e View commit details
    Browse the repository at this point in the history