added learn more link to custom liquid #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoboludo
approved these changes
Jul 5, 2023
Oh good callout, I do think that's an issue. Can we remove that offsite icon? |
ludoboludo
reviewed
Jul 5, 2023
| @@ -658,7 +658,7 @@ | |||
| "settings": { | |||
| "custom_liquid": { | |||
| "label": "Liquid code", | |||
| "info": "Add app snippets or other code to create advanced customizations." | |||
| "info": "Add app snippets or other code to create advanced customizations. [Learn more](https://shopify.dev/docs/api/liquid)" | |||
There was a problem hiding this comment.
The offsite icon was introduced with the online-store-editor and can't be changed in dawn. We would have to create a separate issue/ticket for this @kimberlyoleiro
kmeleta
approved these changes
Jul 12, 2023
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* added learn more link to custom liquid * Update 20 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Custom Liquid section info contains a learn more link.
Why are these changes introduced?
Fixes #2726 .
What approach did you take?
I added a learn more tag that links to an informational page about liquid
Visual impact on existing themes
N/A
Testing steps/scenarios
Demo links
Checklist