Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product_card_style = card now shows placeholder image #2740

Conversation

lougoncharenko
Copy link
Contributor

@lougoncharenko lougoncharenko commented Jun 26, 2023

PR Summary:

The default feature collection will show placeholder images when product card style = card in the global theme settings.

Why are these changes introduced?

Fixes #2466 .

What approach did you take?

  1. I removed the ratio from the card card--{{ settings.card_style }} card--media div and placed it in the card__inner div.
  2. I added a div called media media--transparent that holds the placeholder_image to apply the same styling as the non-default product card gets.
  3. Removed some unnecessary classes in the section that were throwing off the styling of the placeholder product collection

Other considerations

no other consideration at the moment

Visual impact on existing themes

Merchants will see an accurate representation of what their featured collection will look like when the default featured collection product_card_style is set to card

Testing steps/scenarios

  • Test in mobile, tablet, and desktop

Product Card Theme Settings:

  • Test both styles: standard and card
  • Test the text alignment: left, center and right
  • Apply the color scheme
  • Test border styles: thickness, opacity and corner radius.
  • Test Shadow: opacity, horizontal and vertical offset and blur

Demo links

Checklist

Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my testing!

@lougoncharenko lougoncharenko self-assigned this Jun 28, 2023
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's looking good 👍 I didn't notice any issues.

Tested:

  • standard style
  • card style
  • with and without borders
  • with and without border radius
  • mobile and desktop

Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lougoncharenko lougoncharenko merged commit 96224e4 into main Jun 29, 2023
@lougoncharenko lougoncharenko deleted the add-placeholder-images-to-featured-collection-when-product-card-style-=-card branch June 29, 2023 15:19
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* product_card_style = card now shows placeholder image

* implemented code review changes

* formatted document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Placeholder Images to Featured Collection when Product Card Style = Card
4 participants