-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
product_card_style = card now shows placeholder image #2740
product_card_style = card now shows placeholder image #2740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well in my testing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's looking good 👍 I didn't notice any issues.
Tested:
- standard style
- card style
- with and without borders
- with and without border radius
- mobile and desktop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* product_card_style = card now shows placeholder image * implemented code review changes * formatted document
PR Summary:
The default feature collection will show placeholder images when product card style = card in the global theme settings.
Why are these changes introduced?
Fixes #2466 .
What approach did you take?
card card--{{ settings.card_style }} card--media
div and placed it in thecard__inner
div.media media--transparent
that holds the placeholder_image to apply the same styling as the non-default product card gets.Other considerations
no other consideration at the moment
Visual impact on existing themes
Merchants will see an accurate representation of what their featured collection will look like when the default featured collection product_card_style is set to card
Testing steps/scenarios
Product Card Theme Settings:
Demo links
Checklist