Removing "my" from cart popup notification #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissaperreault
requested review from
katycobb,
ludoboludo and
kmeleta
and removed request for
ludoboludo and
kmeleta
|
@ludoboludo @kmeleta Mostly need your thumbs up so I can request translations first 🙏 Thank you! |
kmeleta
previously approved these changes
Mar 3, 2023
ludoboludo
previously approved these changes
Mar 3, 2023
translation-platform
bot
dismissed stale reviews from ludoboludo, kmeleta, and katycobb
via
a85c6d8
ludoboludo
approved these changes
Mar 7, 2023
kmeleta
approved these changes
Mar 8, 2023
chris-kreidl
added a commit
to uniorusa/unior-usa-b2b
that referenced
this pull request
Mar 10, 2023
Removing "my" from cart popup notification (Shopify#2353)
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Mar 11, 2023
* shopify/main: Improve image sizes in the multicolumn section (Shopify#2349) Fix the Page section's width. (Shopify#2364) Update 12 translation files (Shopify#2366) Removing "my" from cart popup notification (Shopify#2353) [Cart.js] Fix fetch url so it's not hard coded (Shopify#2357) (Shopify#2365) Update 1 translation file (Shopify#2352) Default Follow on Shop to on [Header] Add localization selectors (Shopify#2258) Remove async CSS pattern where it may introduce layout shifts (Shopify#2270) Change rich text section heading to be of type inline_richtext, also moved rte styling into base.css (Shopify#2326) Add drawer menu desktop (Shopify#2195) Make header image preload and proper width (Shopify#2307)
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* remove my word * Update 18 translation files * Update 8 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Update the Popup notification content to remove the possessive word "my" for better language consistency.
Why are these changes introduced?
Fixes https://github.com/Shopify/checkout-web/issues/18246
The original problem that was flagged: inconsistent use of “My” vs. “Your” account on a single modal
Easily fixed with copy update to remove “my”.
What approach did you take?
Removed the unwanted word.
Other considerations
There are some Admin content placeholder label that I couldn't change but it doesn't seem like this content is rendered on merchants' storefront, except if they are willing to accept the placeholder recommendation. It was less a priority and I couldn't find where I could make that change.
Visual impact on existing themes
This will change slightly the language on the button text and how we communicate with buyers to the best.
Testing steps/scenarios
Popup notificationView cartinstead ofView my cart.Demo links
Checklist