Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PULL_REQUEST_TEMPLATE.md #1892

Merged
merged 7 commits into from
Aug 11, 2022
Merged

Update PULL_REQUEST_TEMPLATE.md #1892

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d79df5
Update PULL_REQUEST_TEMPLATE.md
melissaperreault Aug 4, 2022
724ff94
Update PULL_REQUEST_TEMPLATE.md
melissaperreault Aug 4, 2022
21e7d70
Update .github/PULL_REQUEST_TEMPLATE.md
melissaperreault Aug 4, 2022
b33ef30
Update .github/PULL_REQUEST_TEMPLATE.md
melissaperreault Aug 5, 2022
b489b28
Apply suggestions from code review
melissaperreault Aug 5, 2022
4276ee1
Update .github/PULL_REQUEST_TEMPLATE.md
melissaperreault Aug 5, 2022
26318b5
Edit based on feedback
melissaperreault Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
**PR Summary:**

_Please include a short description (using non-technical terms, 1-2 sentences) about the changes you are introducing, what problem is being fixed and/or describe the benefit to merchants. This content will be used in our release notes for Dawn on [themes.shopify.com](https://themes.shopify.com/themes/dawn/styles/default#ReleaseNotes)._
<!-- Please include a short description (using non-technical terms, 1-2 sentences) about the changes you are introducing, what problem is being fixed and/or describe the benefit to merchants. This content will be used in our release notes for Dawn on [themes.shopify.com](https://themes.shopify.com/themes/dawn/styles/default#ReleaseNotes). -->
martinamarien marked this conversation as resolved.
Show resolved Hide resolved


**Why are these changes introduced?**
Expand All @@ -18,17 +18,19 @@ Fixes #0.
| 1 | | | | |

**Testing steps/scenarios**
- [ ] _List all the testing tasks that applies to your fix and help peers to review your work._
<!-- List all the testing tasks that applies to your fix to help peers review your work. -->
- [ ] Step 1

**Demo links**
_Please include a link to a demo store that includes preconfigured sections and settings to allow reviewers to easily test the features you are working on._
<!-- Please include a link to a demo store that includes preconfigured sections and settings to allow reviewers to easily test the features you are working on. -->

- [Store](url)
- [Editor](url)

**Checklist**
- [ ] Added PR summary for [release notes](https://themes.shopify.com/themes/dawn/styles/default#ReleaseNotes)
melissaperreault marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Notified the [help.shopify.com](https://help.shopify.com) team about updates to theme settings (current contact: Kimli)
- [ ] Requested review from UX (Only for changes that are affecting the experience or perceivable visual details.)
melissaperreault marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Created a ticket on the Help repository to notify the [help.shopify.com](https://help.shopify.com) team about updates to theme settings. (Internal-only task)
melissaperreault marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Followed [theme code principles](https://github.com/Shopify/dawn/blob/main/.github/CONTRIBUTING.md#theme-code-principles)
- [ ] Linted with [Theme Check](https://github.com/Shopify/theme-check)
- [ ] Tested on [mobile](https://shopify.dev/themes/store/requirements#mobile-browser-requirements)
Expand Down