Add padding to collection banner section #1808
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is draft PR to show an alternative solution for: #1790
Store demo link
Testing steps/scenarios
1600px
:Notes for this draft PR
(We should probably fix this in another PR)
While I was testing the removal of:
dawn/assets/component-collection-hero.css
Lines 13 to 14 in 8d0e9fb
I realized the condition of the
--page-width-margin
CSS variable in layout >password.liquid
,theme.liquid
, andgift_card.liquid
didn't work correctly due to1600
being wrapper in single quotes (not sure if this was a recent change in the backend):dawn/layout/theme.liquid
Line 87 in 8d0e9fb
So when you set the global settings > Layout > Page width to
1600px
, the CSS variable of--page-width-margin
was still0rem
and not the expected2rem
. This still needs to work since this PR uses the same CSS but moved into the section file ofmain-collection-banner.liquid
.TL;DR - for this draft PR, I removed those single quotes and validated that it works as expected:
CC: @kjellr