Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to adjust announcement bar font size #1778

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
+340 −1
Open

Add option to adjust announcement bar font size #1778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
48f6de0
Try adding font size options to the announcement bar
kjellr Jun 10, 2022
f19d799
Get font size classes working.
kjellr Jun 10, 2022
777e81f
Scale up on larger screens.
kjellr Jun 10, 2022
094fd98
Sync up the font size with h3.
kjellr Jun 10, 2022
866361b
Have medium match the body font size.
kjellr Jun 10, 2022
3d45368
Use the cascade. 🙂
kjellr Jun 10, 2022
bceff47
Rearrange the settings.
kjellr Jun 10, 2022
59a8898
Modify font sizes.
kjellr Jun 14, 2022
e0fb641
Add line-height and letter-spacing rules.
kjellr Jun 17, 2022
0be9f40
Add specs for the medium size too.
kjellr Jun 17, 2022
50a18ef
Try using existing classnames.
kjellr Jun 21, 2022
1584db5
Update 2 translation files
translation-platform[bot] Jun 30, 2022
753f5a4
Update 16 translation files
translation-platform[bot] Jul 1, 2022
0509fee
Update 1 translation file
translation-platform[bot] Jul 2, 2022
fef8ece
Update 1 translation file
translation-platform[bot] Jul 6, 2022
e66c83b
Merge branch 'main' into try/announcement-font-size
kjellr Jul 7, 2022
1c1f98d
Merge branch 'main' into try/announcement-font-size
kjellr Jul 8, 2022
cd7bcb7
Fix JSON
kjellr Jul 8, 2022
1e746de
Update locales/en.default.schema.json
kjellr Jul 11, 2022
05051a6
Merge branch 'main' into try/announcement-font-size
kjellr Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions locales/cs.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Odkaz"
},
"text_size": {
"label": "Velikost textu",
"options__1": {
"label": "Malý"
},
"options__2": {
"label": "Střední"
},
"options__3": {
"label": "Velký"
},
"options__4": {
"label": "Extra velký"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/da.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Link"
},
"text_size": {
"label": "Tekststørrelse",
"options__1": {
"label": "Lille"
},
"options__2": {
"label": "Medium"
},
"options__3": {
"label": "Stor"
},
"options__4": {
"label": "Ekstra stor"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/de.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,21 @@
"link": {
"label": "Link"
},
"text_size": {
"label": "Textgröße",
"options__1": {
"label": "Klein"
},
"options__2": {
"label": "Mittel"
},
"options__3": {
"label": "Groß"
},
"options__4": {
"label": "Extra groß"
}
},
"text_alignment": {
"label": "Textausrichtung",
"options__1": {
Expand Down
15 changes: 15 additions & 0 deletions locales/en.default.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,21 @@
"text": {
"label": "Text"
},
"text_size": {
"label": "Text size",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Text size for key sections.announcement-bar.blocks.announcement.settings.text_size.label is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

"options__1": {
"label": "Small"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Small for key sections.announcement-bar.blocks.announcement.settings.text_size.options__1.label is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

},
"options__2": {
"label": "Medium"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Medium for key sections.announcement-bar.blocks.announcement.settings.text_size.options__2.label is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

},
"options__3": {
"label": "Large"
},
"options__4": {
"label": "Extra Large"
}
},
"text_alignment": {
"label": "Text alignment",
"options__1": {
Expand Down
15 changes: 15 additions & 0 deletions locales/es.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Enlace"
},
"text_size": {
"label": "Tamaño del texto",
"options__1": {
"label": "Pequeño"
},
"options__2": {
"label": "Mediano"
},
"options__3": {
"label": "Grande"
},
"options__4": {
"label": "Extra grande"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/fi.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Linkki"
},
"text_size": {
"label": "Tekstin koko",
"options__1": {
"label": "Pieni"
},
"options__2": {
"label": "Keskisuuri"
},
"options__3": {
"label": "Suuri"
},
"options__4": {
"label": "Erikoissuuri"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/fr.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Lien"
},
"text_size": {
"label": "Taille du texte",
"options__1": {
"label": "Petit"
},
"options__2": {
"label": "Moyen"
},
"options__3": {
"label": "Grand"
},
"options__4": {
"label": "Très grand"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/it.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Link"
},
"text_size": {
"label": "Dimensione testo",
"options__1": {
"label": "Piccola"
},
"options__2": {
"label": "Media"
},
"options__3": {
"label": "Grande"
},
"options__4": {
"label": "Molto grande"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/ja.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,21 @@
},
"link": {
"label": "リンク"
},
"text_size": {
"label": "テキストサイズ",
"options__1": {
"label": "小"
},
"options__2": {
"label": "中"
},
"options__3": {
"label": "大"
},
"options__4": {
"label": "特大"
}
}
},
"name": "告知"
Expand Down
15 changes: 15 additions & 0 deletions locales/ko.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,21 @@
},
"link": {
"label": "링크"
},
"text_size": {
"label": "텍스트 사이즈",
"options__1": {
"label": "작게"
},
"options__2": {
"label": "보통"
},
"options__3": {
"label": "크게"
},
"options__4": {
"label": "아주 크게"
}
}
},
"name": "공지"
Expand Down
15 changes: 15 additions & 0 deletions locales/nb.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Kobling"
},
"text_size": {
"label": "Tekststørrelse",
"options__1": {
"label": "Liten"
},
"options__2": {
"label": "Middels"
},
"options__3": {
"label": "Stor"
},
"options__4": {
"label": "Ekstra stor"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/nl.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Link"
},
"text_size": {
"label": "Tekstgrootte",
"options__1": {
"label": "Klein"
},
"options__2": {
"label": "Gemiddeld"
},
"options__3": {
"label": "Groot"
},
"options__4": {
"label": "Extra groot"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/pl.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Link"
},
"text_size": {
"label": "Rozmiar tekstu",
"options__1": {
"label": "Mały"
},
"options__2": {
"label": "Średni"
},
"options__3": {
"label": "Duży"
},
"options__4": {
"label": "Bardzo duży"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/pt-BR.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Link"
},
"text_size": {
"label": "Tamanho do texto",
"options__1": {
"label": "Pequeno"
},
"options__2": {
"label": "Médio"
},
"options__3": {
"label": "Grande"
},
"options__4": {
"label": "Extra grande"
}
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions locales/pt-PT.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,21 @@
},
"link": {
"label": "Ligação"
},
"text_size": {
"label": "Tamanho do texto",
"options__1": {
"label": "Pequeno"
},
"options__2": {
"label": "Médio"
},
"options__3": {
"label": "Grande"
},
"options__4": {
"label": "Extra grande"
}
}
},
"name": "Comunicado"
Expand Down
15 changes: 15 additions & 0 deletions locales/sv.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,21 @@
},
"link": {
"label": "Länk"
},
"text_size": {
"label": "Textstorlek",
"options__1": {
"label": "Liten"
},
"options__2": {
"label": "Medel"
},
"options__3": {
"label": "Stor"
},
"options__4": {
"label": "Extra stor"
}
}
},
"name": "Meddelande"
Expand Down
15 changes: 15 additions & 0 deletions locales/th.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,21 @@
},
"link": {
"label": "ลิงก์"
},
"text_size": {
"label": "ขนาดตัวอักษร",
"options__1": {
"label": "เล็ก"
},
"options__2": {
"label": "ปานกลาง"
},
"options__3": {
"label": "ใหญ่"
},
"options__4": {
"label": "ใหญ่พิเศษ"
}
}
},
"name": "การประกาศ"
Expand Down
15 changes: 15 additions & 0 deletions locales/tr.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@
},
"link": {
"label": "Bağlantı"
},
"text_size": {
"label": "Metin boyutu",
"options__1": {
"label": "Küçük"
},
"options__2": {
"label": "Orta"
},
"options__3": {
"label": "Büyük"
},
"options__4": {
"label": "Çok Büyük"
}
}
}
}
Expand Down
Loading