-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try adding a CSS-only announcement bar marquee option #1777
Conversation
Committed from shop: Pressed
…pify/dawn into try/announcement-bar-marquee
Hey @svinkle , this is only a proof of concept PR but would like to learn if turning off automatically the scrolling if user's device has I suspect we would need to offer control to play/pause the animation additionally? |
+1 to Melissa's comment. I think we will need to add a play/pause button. When working on header improvements, I designed one here if that is helpful. Also, not sure if a setting to control the speed could be helpful. We have a speed setting on the slideshow. Screenshot |
The more I sit on this one, the less sure I am that it should be in Dawn in the first place. Marquees are super-trendy right now, but they're not a great pattern from a usability perspective (hence all the questions above about accessibility and pause buttons). Because of that, I'm weary of unleashing it on all of our themes at once. I'm also not sure it makes sense to include it from a theme framework perspective: marquees will fade in trendiness at some point, and we'll still have this built-in to Dawn. I'm not convinced it's a feature that's core to commerce. Instead, it might make sense to make this a quick app, or even just a feature in one or two specific themes that are designed to be more trendy/ephemeral. |
Committed from shop: Pressed
Implementing a non-rotating fallback via As with any wide-sweeping motion, an explicit method to pause is recommended. |
Hey @kjellr, The probot-CLA was recently deprecated. This pull request will now need to refer to new shopify-cla CLA check. One way to achieve this is by closing and reopening this pull request. I apologize for the noise. Feel free to message me if you have any questions 😄 Update Looks like the shopify[bot] might be preventing the CLA check to pass: |
We have received a translation request but there is a question blocking translation work. Your help is needed. Please answer the following questions.
|
I'm just going to go ahead and close this one — it was just a proof of concept, and I think the method used here isn't viable anyway due to issues with long text strings and different viewports. |
PR Summary:
Adds a "Scrolling marquee" option to the announcement bar.
10-32-uwyun-2p4vy.mp4
Why are these changes introduced?
Just a proof of concept.
What approach did you take?
The PR uses a simple CSS animation to create an endlessly scrolling marquee. It borrows this idea for using text shadows to repeat the text. This generally works for text, but breaks if you use emoji. 😞
Aside from the emoji issue, I don't think this is actually a viable option for a couple reasons though:
Both of these could theoretically be handled by JS, but I think we'd want to explore that outside of this PR anyway. Keeping this as a draft for now, but it should probably be closed once we've taken a look at it.
Other considerations
The PR automatically turns the scrolling off if the user's device has
Prefers reduced motion
set.Testing steps/scenarios