Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility add h2 to drawer filter #1564

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −1
Open

Accessibility add h2 to drawer filter #1564

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f324fc6
Accessibility add h2 to drawer
Mar 31, 2022
8830412
Feedback
sofiamatulis Mar 31, 2022
d516f48
conflict
sofiamatulis Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion snippets/facets.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@
<div class="mobile-facets__inner gradient">
<div class="mobile-facets__header">
<div class="mobile-facets__header-inner">
<h2 class="mobile-facets__heading medium-hide large-up-hide">
<h2 class="mobile-facets__heading medium-hide large-up-hide" id="verticalTitle" tabindex="-1">
Copy link
Contributor

@martinamarien martinamarien Mar 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we need the tabindex on the heading? I don't think I understand why it's needed. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required for the mobile/drawer context but is required when we implement #109.

{%- if enable_filtering and enable_sorting -%}
{{ 'products.facets.filter_and_sort' | t }}
{%- elsif enable_filtering -%}
Expand Down