Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text opacity a11y #1539

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+625 −614
Open

Text opacity a11y #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30655d3
fix links for product rating
melissaperreault Mar 24, 2022
98f0b01
Update 20 translation files
translation-platform[bot] Mar 24, 2022
d1a5478
update os2 links and remove /en
melissaperreault Mar 25, 2022
0230f41
Remove the opacity on most of our text colors
ludoboludo Mar 25, 2022
85d78f9
add comments where I could/should maybe edit the opacity
ludoboludo Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions assets/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ body,
.color-inverse,
.color-accent-1,
.color-accent-2 {
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
background-color: rgb(var(--color-background));
}

Expand Down Expand Up @@ -454,14 +454,14 @@ h5,

h6,
.h6 {
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
margin-block-start: 1.67em;
margin-block-end: 1.67em;
}

blockquote {
font-style: italic;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
border-left: 0.2rem solid rgba(var(--color-foreground), 0.2);
padding-left: 1rem;
}
Expand Down Expand Up @@ -1674,7 +1674,7 @@ details[open] > .share-button__fallback {
font-style: var(--font-body-style);
font-weight: var(--font-body-weight);
font-size: 1.2rem;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
}

.field:hover.field:after,
Expand Down Expand Up @@ -1776,7 +1776,7 @@ details[open] > .share-button__fallback {
position: absolute;
transition: top var(--duration-short) ease,
font-size var(--duration-short) ease;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
letter-spacing: 0.1rem;
line-height: 1.5;
}
Expand Down Expand Up @@ -2274,7 +2274,7 @@ input[type='checkbox'] {

.header__heading-link .h2 {
line-height: 1;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
}

.header__heading-logo {
Expand Down Expand Up @@ -2576,7 +2576,7 @@ details[open] > .header__submenu {
.header__menu-item {
padding: 1.2rem;
text-decoration: none;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
}

.header__menu-item:hover {
Expand Down
2 changes: 1 addition & 1 deletion assets/component-cart.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ cart-items {
line-height: 1;
height: 1.8rem;
top: -3rem;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
}

.cart__note .field__input {
Expand Down
4 changes: 3 additions & 1 deletion assets/component-facets.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@

.facets__heading {
display: block;
/* Remove here too ? */
color: rgba(var(--color-foreground), 0.85);
font-size: 1.4rem;
margin: -1.5rem 2rem 0 0;
Expand All @@ -197,7 +198,7 @@
}

.facets__summary {
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
font-size: 1.4rem;
margin-bottom: 1.5rem;
padding: 0 1.75rem 0 0;
Expand Down Expand Up @@ -590,6 +591,7 @@ a.active-facets__button.focused .active-facets__button-inner,
}

.mobile-facets__count {
/* Should I remove the opacity here too ? */
color: rgba(var(--color-foreground), 0.7);
font-size: 1.3rem;
margin: 0;
Expand Down
4 changes: 2 additions & 2 deletions assets/component-mega-menu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
background-color: rgb(var(--color-background));
border-left: 0;
border-radius: 0;
border-right: 0;
border-right: 0;
left: 0;
max-height: calc(100vh - var(--header-bottom-position-desktop, 20rem) - 4rem);
overflow-y: auto;
Expand Down Expand Up @@ -47,7 +47,7 @@
}

.mega-menu__link {
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
display: block;
line-height: calc(1 + 0.3 / var(--font-body-scale));
padding-bottom: 0.8rem;
Expand Down
2 changes: 1 addition & 1 deletion assets/component-pickup-availability.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ pickup-availability[available] {

.pickup-availability-button {
background-color: transparent;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
letter-spacing: 0.06rem;
padding: 0 0 0.2rem;
text-align: left;
Expand Down
2 changes: 2 additions & 0 deletions assets/component-predictive-search.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ predictive-search[loading] .predictive-search {
justify-content: space-between;
align-items: center;
width: calc(100% - 4rem);
/* Remove opacity here too? */
color: rgba(var(--color-foreground), 0.7);
}

Expand Down Expand Up @@ -137,6 +138,7 @@ predictive-search[loading] .predictive-search__results-list:first-child {
}

.predictive-search__item .price {
/* remove opacity here too ? */
color: rgba(var(--color-foreground), 0.7);
font-size: 1.2rem;
}
Expand Down
3 changes: 2 additions & 1 deletion assets/component-price.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@

.price--on-sale .price-item--regular {
text-decoration: line-through;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
font-size: 1.3rem;
}

Expand All @@ -91,5 +91,6 @@
line-height: calc(1 + 0.2 / var(--font-body-scale));
margin-top: 0.2rem;
text-transform: uppercase;
/* change/remove opacity here too? */
color: rgba(var(--color-foreground), 0.7);
}
3 changes: 2 additions & 1 deletion assets/component-slider.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ slider-component.slider-component-full-width {
}

.slider-counter__link--numbers {
/* change opacity here too ? */
color: rgba(var(--color-foreground), 0.5);
text-decoration: none;
}
Expand Down Expand Up @@ -328,7 +329,7 @@ slider-component.slider-component-full-width {
}

.slider-button {
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
background: transparent;
border: none;
cursor: pointer;
Expand Down
2 changes: 1 addition & 1 deletion assets/component-slideshow.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ slideshow-component:not(.page-width) .slider-buttons {
}

.slideshow__autoplay path {
fill: rgba(var(--color-foreground), 0.75);
fill: rgb(var(--color-foreground));
}

.slideshow__autoplay:hover path {
Expand Down
4 changes: 3 additions & 1 deletion assets/customer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@
}

.customer td::before {
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
content: attr(data-label);
font-size: 1.4rem;
padding-right: 2rem;
Expand Down Expand Up @@ -628,6 +628,7 @@
}

.order dd s {
/* Change opacity ? */
color: rgba(var(--color-foreground), 0.7);
}

Expand All @@ -637,6 +638,7 @@
line-height: calc(1 + 0.2 / var(--font-body-scale));
margin-top: 0.2rem;
text-transform: uppercase;
/* remove opacity here too ? */
color: rgba(var(--color-foreground), 0.7);
}

Expand Down
2 changes: 1 addition & 1 deletion assets/section-blog-post.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
}

.article-template__comments-comment {
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
background-color: rgb(var(--color-background));
margin-bottom: 1.5rem;
padding: 2rem 2rem 1.5rem;
Expand Down
2 changes: 1 addition & 1 deletion assets/section-featured-blog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

.blog-placeholder .rte-width {
margin-top: 1.2rem;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
}

@media screen and (min-width: 990px) {
Expand Down
6 changes: 3 additions & 3 deletions assets/section-footer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@

.footer__localization h2 {
margin: 1rem 1rem 0.5rem;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
}

@media screen and (min-width: 750px) {
Expand Down Expand Up @@ -413,7 +413,7 @@ noscript .localization-selector.link {

.footer-block__details-content .list-menu__item--link,
.copyright__content a {
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
}

.footer-block__details-content .list-menu__item--active {
Expand Down Expand Up @@ -485,7 +485,7 @@ noscript .localization-selector.link {

.footer .disclosure__link {
padding: 0.95rem 3.5rem 0.95rem 2rem;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
}

.footer .disclosure__link:hover {
Expand Down
7 changes: 5 additions & 2 deletions assets/section-main-product.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ fieldset.product-form__input .form__label {
a.product__text {
display: block;
text-decoration: none;
color: rgba(var(--color-foreground), 0.75);
color: rgb(var(--color-foreground));
}

.product__text.caption-with-letter-spacing {
Expand Down Expand Up @@ -357,7 +357,7 @@ a.product__text {
.product__info-container {
max-width: 60rem;
}

.product__info-container .price--on-sale .price-item--regular {
font-size: 1.6rem;
}
Expand Down Expand Up @@ -741,6 +741,7 @@ a.product__text {
background-color: rgb(var(--color-background));
border: 0.1rem solid rgba(var(--color-foreground), 0.1);
border-radius: 50%;
/* change opacity ? */
color: rgba(var(--color-foreground), 0.55);
display: flex;
align-items: center;
Expand Down Expand Up @@ -934,6 +935,7 @@ a.product__text {
background-color: rgb(var(--color-background));
border: 0.1rem solid rgba(var(--color-foreground), 0.1);
border-radius: 50%;
/* change/remove opacity here ? */
color: rgba(var(--color-foreground), 0.55);
display: flex;
align-items: center;
Expand Down Expand Up @@ -1125,6 +1127,7 @@ a.product__text {
}

.thumbnail__badge {
/* change opacity here ? */
color: rgb(var(--color-foreground), 0.6);
height: 2rem;
width: 2rem;
Expand Down
2 changes: 1 addition & 1 deletion config/settings_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"theme_name": "Dawn",
"theme_version": "4.0.0",
"theme_author": "Shopify",
"theme_documentation_url": "https://help.shopify.com/en/manual/online-store/themes",
"theme_documentation_url": "https://help.shopify.com/manual/online-store/themes",
"theme_support_url": "https://support.shopify.com/"
},
{
Expand Down
Loading