Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mega menu content layout and styles #1338

Merged
merged 23 commits into from
Mar 7, 2022
Merged

Add mega menu content layout and styles #1338

merged 23 commits into from
Mar 7, 2022

Commits on Feb 9, 2022

  1. Add grid for mega menu content and styles for links

    @KaichenWang
    KaichenWang committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    c8eb925 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Merge branch 'add-mega-menu' of https://github.com/Shopify/dawn into … 

    …add-mega-menu-content

# Conflicts:
#	assets/component-mega-menu.css
    @KaichenWang
    KaichenWang committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    c6072ef View commit details
    Browse the repository at this point in the history

  2. Remove role="list" from ul elements since list is ul elements' defaul… 

    …t role
    @KaichenWang
    KaichenWang committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    9e48c1d View commit details
    Browse the repository at this point in the history

  3. Adjust link styles

    @KaichenWang
    KaichenWang committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    9bc5135 View commit details
    Browse the repository at this point in the history

  4. Set mega menu content max height based on viewport height. Use header… 

    … bottom position set in JS for calculation
    @KaichenWang
    KaichenWang committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    1df2554 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Round position value down instead of up to be more consistent with ot… 

    …her instances where --header-bottom-position value is set in JS
    @KaichenWang
    KaichenWang committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    00c3611 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-mega-menu' of https://github.com/Shopify/dawn into … 

    …add-mega-menu-content
    @KaichenWang
    KaichenWang committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    c2e683f View commit details
    Browse the repository at this point in the history

  3. Fix spacing

    @KaichenWang
    KaichenWang committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    b1fdb18 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Change level 2 link color to better distinguish from level 3 links

    @KaichenWang
    KaichenWang committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    7259216 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Revert mega menu heading opacity to improve color contrast

    @KaichenWang
    KaichenWang committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    81450ce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-mega-menu' of https://github.com/Shopify/dawn into … 

    …add-mega-menu-content

# Conflicts:
#	snippets/mega-menu.liquid
    @KaichenWang
    KaichenWang committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    6dc76a7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'add-mega-menu' of https://github.com/Shopify/dawn into … 

    …add-mega-menu-content

# Conflicts:
#	snippets/mega-menu.liquid
    @KaichenWang
    KaichenWang committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    7980df6 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Merge branch 'add-mega-menu' of https://github.com/Shopify/dawn into … 

    …add-mega-menu-content

# Conflicts:
#	assets/component-mega-menu.css
#	sections/header.liquid
    @KaichenWang
    KaichenWang committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    d3b72d4 View commit details
    Browse the repository at this point in the history

  2. Add id to mega menu content container (JS will use id to add aria-con… 

    …trol attribute to summary element). Add role="list" to ul in mega menu for a11y (when list bullets are removed some assistive technologies may not convey ul as list without explicit role)
    @KaichenWang
    KaichenWang committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    e357411 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @KaichenWang
    KaichenWang committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    cd322bf View commit details
    Browse the repository at this point in the history

  4. Combine css properties for same class

    @KaichenWang
    KaichenWang committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    7581e8f View commit details
    Browse the repository at this point in the history

  5. Set mega menu links to display block to ensure bigger touch target

    @KaichenWang
    KaichenWang committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    544968b View commit details
    Browse the repository at this point in the history

  6. Add some bottom offset to menu max-height to prevent iOS Safari from … 

    …cutting off bottom of menu
    @KaichenWang
    KaichenWang committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    2f854a4 View commit details
    Browse the repository at this point in the history

  7. Update link style (remove uppercase) for 2nd level links that have no… 

    … children
    @KaichenWang
    KaichenWang committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    283e242 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Update L2 link font to bold. Use Liquid to calculate bold font-weight… 

    … value: "bold" will be +300 relative to default body font-weight, but restricted to max of 1000
    @KaichenWang
    KaichenWang committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    2b14cee View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Address feedback. Add explicit role="list" for a11y (when list bullet… 

    …s are removed some assistive technologies may not convey ul as list without explicit role)
    @KaichenWang
    KaichenWang committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    cff04b6 View commit details
    Browse the repository at this point in the history

  2. Use rem instead of px

    @KaichenWang
    KaichenWang committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    630713d View commit details
    Browse the repository at this point in the history

  3. Remove redundant css

    @KaichenWang
    KaichenWang committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    fb5671f View commit details
    Browse the repository at this point in the history