-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat. collection updates #1295
Merged
Merged
Feat. collection updates #1295
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
13b2b2b
Feat. collection updates
ludoboludo e13619e
add uppercase option
ludoboludo 2b9742e
updates to add slider option on desktop
ludoboludo 7256df0
change data step to 1 for the time being
ludoboludo a5c1c1d
remove existing swipe settings
ludoboludo 8cc4740
change setting order, limit the horizontal offset
ludoboludo 55f9b3c
add period
ludoboludo 43c969c
remove peek and scroll snap padding
ludoboludo a3e4559
move description chekbox around and adjust copy
ludoboludo 46e1569
add checkboxes to enable carousel on desktop and mobile
ludoboludo aaefcb5
use a new slider--desktop class
ludoboludo a4589ab
Merge branch 'main' into feat-collection
ludoboludo f3b2ccf
remove heading class and add a11y attributes
ludoboludo b204e36
re add grid peek behaviour at all time on mobile
ludoboludo 19e42e5
fix media query and remove unnecessary styling
ludoboludo de421ec
edit copy
ludoboludo 8154155
start exploring grid peek on desktop
ludoboludo 881dd6b
add grid peek by default on desktop
ludoboludo 35015be
fix page width depending on scenarios and adjust slide width
ludoboludo 7123217
fix slider disabled button on wide screens. Remove settings added in …
ludoboludo 4d34092
Merge branch 'main' into feat-collection
ludoboludo 1aac0bc
change the calculation for item width based on the number of items pe…
ludoboludo a6a3ea0
change total calculation for slide counter
ludoboludo 8c94a58
add full width setting
ludoboludo 88f5165
Merge branch 'main' into feat-collection
ludoboludo f4a4b0d
fix full width CSS styling specificity
ludoboludo d4f48c1
fix pages calculation to work on desktop
ludoboludo 9cfbc2c
address some of the UX feedback
ludoboludo 2b96ef8
add spacing for shadows
ludoboludo 62ba6c2
address reviewer's comments
ludoboludo 0f51041
Edit copy
ludoboludo 39050ce
edit copy
ludoboludo 9b6c6b5
Update 21 translation files
translation-platform[bot] f816e38
Update 1 translation file
translation-platform[bot] 521f312
Update 13 translation files
translation-platform[bot] 1cd72e1
Update 1 translation file
translation-platform[bot] 221287e
Update 6 translation files
translation-platform[bot] e31b11f
Update 2 translation files
translation-platform[bot] 11e5424
Update 19 translation files
translation-platform[bot] a1f2824
Merge branch 'main' into feat-collection
ludoboludo 219ee7e
fix translation comma
ludoboludo 98f1e41
Merge branch 'main' into feat-collection
ludoboludo e4c2a27
Merge branch 'main' into feat-collection
ludoboludo 24ecfba
reuse assign to hide slider controls
ludoboludo 50ba6ec
move styling to be more general
ludoboludo 1e1b287
fix UX feedback
ludoboludo 078276a
Address Lucas' feedback
ludoboludo 32f6cd4
reorder setting
ludoboludo b54d81f
remove unused custom properties
ludoboludo 2229142
fix class specificity
ludoboludo 8a43e00
remove redundant page-width-mobile class
ludoboludo 81c2759
address reviewer's comment
ludoboludo b72f770
apply reduced motion media query to all sliders
ludoboludo 3808adc
remove some CSS
ludoboludo b044959
fix UX feedback
ludoboludo c083fa6
tweak title spacing
ludoboludo fcc3c6e
fix spacing
ludoboludo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,6 +57,10 @@ | |
} | ||
|
||
@media screen and (min-width: 990px) { | ||
.collection__title--desktop-slider .title { | ||
margin-bottom: 2.5rem; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added this so that it accounts for the |
||
} | ||
|
||
.collection__title.title-wrapper--self-padded-tablet-down { | ||
padding: 0 5rem; | ||
} | ||
|
@@ -65,7 +69,7 @@ | |
padding: 0; | ||
} | ||
|
||
.collection--full-width slider-component:not(.collection__slider-desktop) { | ||
.collection--full-width slider-component:not(.slider-component-desktop) { | ||
padding: 0 1.5rem; | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to make this a desktop only thing when the slider is enabled.