Dedupe IDs prior to injecting the new content

Shopify · May 30, 2024 · eca1902 · eca1902
1 parent 1f5fff2
commit eca1902
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/assets/global.js b/assets/global.js
@@ -51,8 +51,6 @@ class HTMLUpdateUtility {
     const newNodeWrapper = document.createElement('div');
     HTMLUpdateUtility.setInnerHTML(newNodeWrapper, newContent.outerHTML);
     const newNode = newNodeWrapper.firstChild;
-    oldNode.parentNode.insertBefore(newNode, oldNode);
-    oldNode.style.display = 'none';
 
     // dedupe IDs
     const uniqueKey = Date.now();
@@ -61,6 +59,9 @@ class HTMLUpdateUtility {
       element.form && element.setAttribute('form', `${element.form.getAttribute('id')}-${uniqueKey}`);
     });
 
+    oldNode.parentNode.insertBefore(newNode, oldNode);
+    oldNode.style.display = 'none';
+
     this.#postProcessCallbacks.forEach((callback) => callback(newNode));
 
     setTimeout(() => oldNode.remove(), 500);