Remove menu title requirement (#1763)

* Menu heading Remove requirement for menu heading in footer to display * Update footer.liquid * Remove helper text * Remove translations * Update footer * Update footer * Update footer * Update footer * Revert changes * Fixes * Update * Update to footer
Shopify · Jun 13, 2022 · a698b09 · a698b09
1 parent 21468ab
commit a698b09
Show file tree

Hide file tree

Showing 22 changed files with 24 additions and 46 deletions.
diff --git a/locales/cs.schema.json b/locales/cs.schema.json
@@ -692,8 +692,7 @@
           "name": "Nabídka",
           "settings": {
             "heading": {
-              "label": "Nadpis",
-              "info": "Pokud chcete zobrazit nabídku, je nutný nadpis."
+              "label": "Nadpis"
             },
             "menu": {
               "label": "Nabídka",

diff --git a/locales/da.schema.json b/locales/da.schema.json
@@ -692,8 +692,7 @@
           "name": "Menu",
           "settings": {
             "heading": {
-              "label": "Overskrift",
-              "info": "Der skal angives en overskrift, for at menuen kan vises."
+              "label": "Overskrift"
             },
             "menu": {
               "label": "Menu",

diff --git a/locales/de.schema.json b/locales/de.schema.json
@@ -692,8 +692,7 @@
           "name": "Menü",
           "settings": {
             "heading": {
-              "label": "Überschrift",
-              "info": "Überschrift ist erforderlich, um das Menü anzuzeigen."
+              "label": "Überschrift"
             },
             "menu": {
               "label": "Menü",

diff --git a/locales/en.default.schema.json b/locales/en.default.schema.json
@@ -814,8 +814,7 @@
           "name": "Menu",
           "settings": {
             "heading": {
-              "label": "Heading",
-              "info": "Heading required to display the menu."
+              "label": "Heading"
             },
             "menu": {
               "label": "Menu",

diff --git a/locales/es.schema.json b/locales/es.schema.json
@@ -692,8 +692,7 @@
           "name": "Menú",
           "settings": {
             "heading": {
-              "label": "Encabezado",
-              "info": "Se requiere un título para mostrar el menú."
+              "label": "Encabezado"
             },
             "menu": {
               "label": "Menú",

diff --git a/locales/fi.schema.json b/locales/fi.schema.json
@@ -692,8 +692,7 @@
           "name": "Valikko",
           "settings": {
             "heading": {
-              "label": "Otsikko",
-              "info": "Valikon näyttäminen edellyttää otsikkoa."
+              "label": "Otsikko"
             },
             "menu": {
               "label": "Valikko",

diff --git a/locales/fr.schema.json b/locales/fr.schema.json
@@ -692,8 +692,7 @@
           "name": "Menu",
           "settings": {
             "heading": {
-              "label": "En-tête",
-              "info": "Un titre est nécessaire pour afficher le menu."
+              "label": "En-tête"
             },
             "menu": {
               "label": "Menu",

diff --git a/locales/it.schema.json b/locales/it.schema.json
@@ -692,8 +692,7 @@
           "name": "Menu",
           "settings": {
             "heading": {
-              "label": "Titolo",
-              "info": "Per visualizzare il menu è necessario un titolo."
+              "label": "Titolo"
             },
             "menu": {
               "label": "Menu",

diff --git a/locales/ja.schema.json b/locales/ja.schema.json
@@ -691,8 +691,7 @@
         "link_list": {
           "settings": {
             "heading": {
-              "label": "見出し",
-              "info": "メニューを表示するには見出しが必要です。"
+              "label": "見出し"
             },
             "menu": {
               "label": "メニュー",

diff --git a/locales/ko.schema.json b/locales/ko.schema.json
@@ -691,8 +691,7 @@
         "link_list": {
           "settings": {
             "heading": {
-              "label": "제목",
-              "info": "메뉴를 표시하려면 제목은 필수 사항입니다."
+              "label": "제목"
             },
             "menu": {
               "label": "메뉴",

diff --git a/locales/nb.schema.json b/locales/nb.schema.json
@@ -692,8 +692,7 @@
           "name": "Meny",
           "settings": {
             "heading": {
-              "label": "Overskrift",
-              "info": "Overskrift kreves for å vise menyen."
+              "label": "Overskrift"
             },
             "menu": {
               "label": "Meny",

diff --git a/locales/nl.schema.json b/locales/nl.schema.json
@@ -692,8 +692,7 @@
           "name": "Menu",
           "settings": {
             "heading": {
-              "label": "Opschrift",
-              "info": "Hoofdtekst verplicht om menu weer te geven"
+              "label": "Opschrift"
             },
             "menu": {
               "label": "Menu",

diff --git a/locales/pl.schema.json b/locales/pl.schema.json
@@ -692,8 +692,7 @@
           "name": "Menu",
           "settings": {
             "heading": {
-              "label": "Nagłówek",
-              "info": "Do wyświetlenia menu wymagany jest nagłówek."
+              "label": "Nagłówek"
             },
             "menu": {
               "label": "Menu",

diff --git a/locales/pt-BR.schema.json b/locales/pt-BR.schema.json
@@ -692,8 +692,7 @@
           "name": "Menu",
           "settings": {
             "heading": {
-              "label": "Título",
-              "info": "Título necessário para exibir o menu."
+              "label": "Título"
             },
             "menu": {
               "label": "Menu",

diff --git a/locales/pt-PT.schema.json b/locales/pt-PT.schema.json
@@ -691,8 +691,7 @@
         "link_list": {
           "settings": {
             "heading": {
-              "label": "Cabeçalho",
-              "info": "É necessário um título para apresentar o menu."
+              "label": "Cabeçalho"
             },
             "menu": {
               "label": "Menu",

diff --git a/locales/sv.schema.json b/locales/sv.schema.json
@@ -691,8 +691,7 @@
         "link_list": {
           "settings": {
             "heading": {
-              "label": "Rubrik",
-              "info": "Det krävs rubrik för att visa menyn."
+              "label": "Rubrik"
             },
             "menu": {
               "label": "Meny",

diff --git a/locales/th.schema.json b/locales/th.schema.json
@@ -691,8 +691,7 @@
         "link_list": {
           "settings": {
             "heading": {
-              "label": "หัวเรื่อง",
-              "info": "ต้องมีหัวเรื่องหากต้องการแสดงเมนู"
+              "label": "หัวเรื่อง"
             },
             "menu": {
               "label": "เมนู",

diff --git a/locales/tr.schema.json b/locales/tr.schema.json
@@ -692,8 +692,7 @@
           "name": "Menü",
           "settings": {
             "heading": {
-              "label": "Başlık",
-              "info": "Menünün gösterilmesi için başlık gereklidir."
+              "label": "Başlık"
             },
             "menu": {
               "label": "Menü",

diff --git a/locales/vi.schema.json b/locales/vi.schema.json
@@ -692,8 +692,7 @@
           "name": "Menu",
           "settings": {
             "heading": {
-              "label": "Tiêu đề",
-              "info": "Bắt buộc phải có tiêu đề để hiển thị menu."
+              "label": "Tiêu đề"
             },
             "menu": {
               "label": "Menu",

diff --git a/locales/zh-CN.schema.json b/locales/zh-CN.schema.json
@@ -691,8 +691,7 @@
         "link_list": {
           "settings": {
             "heading": {
-              "label": "标题",
-              "info": "需要具有标题才能显示菜单。"
+              "label": "标题"
             },
             "menu": {
               "label": "菜单",

diff --git a/locales/zh-TW.schema.json b/locales/zh-TW.schema.json
@@ -691,8 +691,7 @@
         "link_list": {
           "settings": {
             "heading": {
-              "label": "標題",
-              "info": "若要顯示選單，則必須要有標題。"
+              "label": "標題"
             },
             "menu": {
               "label": "選單",

diff --git a/sections/footer.liquid b/sections/footer.liquid
@@ -51,7 +51,7 @@
         -%}
         <div class="footer__blocks-wrapper grid grid--1-col grid--2-col grid--4-col-tablet {{ footer_grid_class }}">
           {%- for block in section.blocks -%}
-            <div class="footer-block grid__item{% if block.type == 'link_list' and block.settings.heading != blank %} footer-block--menu{% endif %}" {{ block.shopify_attributes }}>
+            <div class="footer-block grid__item{% if block.type == 'link_list' %} footer-block--menu{% endif %}" {{ block.shopify_attributes }}>
               {%- if block.settings.heading != blank -%}
                 <h2 class="footer-block__heading">{{- block.settings.heading | escape -}}</h2>
               {%- endif -%}
@@ -62,7 +62,7 @@
                     {{ block.settings.subtext }}
                   </div>
                 {%- when 'link_list' -%}
-                  {%- if block.settings.menu != blank and block.settings.heading != blank -%}
+                  {%- if block.settings.menu != blank -%}
                     <ul class="footer-block__details-content list-unstyled">
                       {%- for link in block.settings.menu.links -%}
                         <li>
@@ -402,8 +402,7 @@
           "type": "text",
           "id": "heading",
           "default": "Quick links",
-          "label": "t:sections.footer.blocks.link_list.settings.heading.label",
-          "info": "t:sections.footer.blocks.link_list.settings.heading.info"
+          "label": "t:sections.footer.blocks.link_list.settings.heading.label"
         },
         {
           "type": "link_list",