Fix 'Cannot read properties of null' error in SliderComponent (#2053)

Shopify · Oct 21, 2022 · 67fbde2 · 67fbde2
1 parent 3f89aa5
commit 67fbde2
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/assets/global.js b/assets/global.js
@@ -558,6 +558,10 @@ class SliderComponent extends HTMLElement {
   }
 
   update() {
+    // Temporarily prevents unneeded updates resulting from variant changes
+    // This should be refactored as part of https://github.com/Shopify/dawn/issues/2057
+    if (!this.slider || !this.nextButton) return;
+
     const previousPage = this.currentPage;
     this.currentPage = Math.round(this.slider.scrollLeft / this.sliderItemOffset) + 1;