Skip to content

Commit

Permalink
Add video button aria label (#1728)
Browse files Browse the repository at this point in the history
  • Loading branch information
pizzaz93 authored Jun 20, 2022
1 parent 8d0e9fb commit 3b7a682
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion sections/collage.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
</noscript>
<modal-opener class="no-js-hidden" data-modal="#PopupModal-{{ block.id }}">
<div class="deferred-media">
<button class="deferred-media__poster full-unstyled-link{% if block.settings.image_padding %} collage-card-spacing{% endif %}" type="button" aria-haspopup="dialog" data-media-id="{{ block.settings.video_url.id }}">
<button class="deferred-media__poster full-unstyled-link{% if block.settings.image_padding %} collage-card-spacing{% endif %}" type="button" aria-label="{{ 'sections.video.load_video' | t: description: block.settings.description | escape }}" aria-haspopup="dialog" data-media-id="{{ block.settings.video_url.id }}">
<div class="media media--transparent ratio"{% if block.settings.cover_image != blank %} style="--ratio-percent: {{ 1 | divided_by: block.settings.cover_image.aspect_ratio | times: 100 }}%"{% else %} style="--ratio-percent: 100%"{% endif %}>
<span class="deferred-media__poster-button motion-reduce">
{%- render 'icon-play' -%}
Expand Down
1 change: 1 addition & 0 deletions sections/video.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
id="Deferred-Poster-Modal-{{ section.settings.video_url.id }}"
class="video-section__poster media deferred-media__poster media--landscape"
type="button"
aria-label="{{ 'sections.video.load_video' | t: description: section.settings.description | escape }}"
>
{%- if section.settings.cover_image != blank -%}
<img
Expand Down

0 comments on commit 3b7a682

Please sign in to comment.