Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM - Prototype, format preserving TOML patcher #5642

Draft
wants to merge 1 commit into
base: shauns/04-08-specific_methods_for_patch_app_configuration_file_scenarios
Choose a base branch
from

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Apr 11, 2025

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

shauns commented Apr 11, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Unused devDependencies (1)

Filename devDependencies
package.json @monodon/rust

await expect(echoToml(invalidToml)).rejects.toMatch(/line \d+, column \d+/)
})

test('updating TOML makes minimal changes and preserves as much as possible', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@shauns shauns force-pushed the shauns/04-11-dnm_-_prototype_format_preserving_toml_patcher branch from 44d071c to e2e6401 Compare April 11, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant