Fix bootsnap setup in environments without bundler #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: #488 `ExplicitRequire.with_gems` assumed the provided gems were activated which is only true if `bundler/setup` was required. If bootsnap is used without bundler, then we need to explictly activate the gem before mutating the `$LOAD_PATH`, otherwise the paths appended during gems activation will be lost once we exit `with_gems`.
casperisfine
force-pushed
the
fix-load-error
branch
from
bac4e74 to
7afa951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #488
ExplicitRequire.with_gemsassumed the provided gems were activated which is only true ifbundler/setupwas required.If bootsnap is used without bundler, then we need to explictly activate the gem before mutating the
$LOAD_PATH, otherwise the paths appended during gems activation will be lost once we exitwith_gems.FYI: @fxn