➖ Removes redux-logger and makes use of custom logger middleware #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuintonC
added
Type: Bug 🐛
QuintonC
force-pushed
the
chore/remove-redux-logger
branch
2 times, most recently
from
66af839
to
42b10c5
Compare
|
/snapit |
QuintonC
force-pushed
the
chore/remove-redux-logger
branch
from
42b10c5
to
29184fb
Compare
|
🫰✨ Thanks @QuintonC! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/connect-wallet@0.0.0-snapshot-20230303202422yarn add @shopify/gate-context-client@0.0.0-snapshot-20230303202422yarn add @shopify/tokengate@0.0.0-snapshot-20230303202422 |
QuintonC
requested review from
jamiely,
Soleone,
caropinzonsilva,
lesliexin,
Borahm and
imjameshall
as code owners
Closed
jamiely
reviewed
Mar 3, 2023
QuintonC
force-pushed
the
chore/remove-redux-logger
branch
from
91a5609
to
2bc5b51
Compare
jamiely
reviewed
Mar 3, 2023
| console.groupEnd(); | ||
| } catch (error) { | ||
| console.log('—— log end ——'); | ||
| } |
There was a problem hiding this comment.
👍 this looks much simpler than what was there before. I'm surprised that the tests didn't break.
There was a problem hiding this comment.
Haha what makes you think the tests would've broken? Previously we were just pushing logs into an array that would only ever have a single entry (from what I can tell), so it makes sense to me that it wouldn't have broken.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ What is the context for these changes?
Removes
redux-loggerfrom the package and utilizes our own custom logger middleware. The source for this implementation is a simplified and slimmed down version of theredux-loggercode that not only matches the types of our store, but also one that we have more control over.🕹️ Demonstration
🎩 How can this be tophatted?
✅ Checklist
Tested on mobileN/ATested on multiple browsersN/ATested for accessibilityN/AUpdated relevant documentation for the changes (if necessary)N/A