🐛 Addresses an issue with exported types from shared #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dawn, Default, and Theme were exported without any information since Shared is not a published package. This leads to issues when attempting to pass a theme value to not only the base props for Tokengate and ConnectWalletProvider, but also makes it impossible to understand the type definition of Theme.
QuintonC
force-pushed
the
bugfix/address-shared-types
branch
from
0199d2e
to
c75ce7e
Compare
QuintonC
added
Type: Bug 🐛
QuintonC
requested review from
jamiely,
Soleone,
caropinzonsilva,
lesliexin,
Borahm and
imjameshall
as code owners
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ What is the context for these changes?
Dawn,Default, andThemewere exported without any information sincepackages/sharedis not a published package.This leads to issues when attempting to pass a theme value to not only
Tokengate, but alsoConnectWalletProvider. Additionally, this makes it impossible to understand the type definition ofThemeas well as results in errors when attempting to override some values in any of the provided themes.🕹️ Demonstration
@shopify/connect-wallet@shopify/tokengate✅ Checklist
Tested on mobileN/ATested on multiple browsersN/ATested for accessibilityN/AIncludes unit testsN/AUpdated relevant documentation for the changes (if necessary)N/A