Remove unused variables #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running better-html with verbose output, I get the error: /Library/Ruby/Gems/2.6.0/gems/better_html-1.0.14 /lib/better_html/test_helper/safe_erb_tester.rb:55: warning: assigned but unused variable - tester
Before this change, I get the warning: /Library/Ruby/Gems/2.6.0/gems/better_html-1.0.14 /lib/better_html/tokenizer/base_erb.rb:52: warning: assigned but unused variable - token
|
I think that we can also get rid of the I tested this out for our CI and it passed. @EiNSTeiN- thoughts? |
tomstuart
approved these changes
Aug 3, 2020
|
@tomstuart / @thegedge Looks like this got approved and merged in August but the last release was in May. Would y'all be amenable to cutting a new release with this included? 🙇 ✨ 🍰 |
Merged
|
@maxbeizer I’ve opened #64 to do this. The build has stopped working so I’ll fix that first and then get the release out. |
|
✨ Thank you @tomstuart 🍰 🚀 🎊 |
|
v1.0.16 is now released with this change 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 hello, friends!
In the latest release, I'm getting the following warnings when running the https://github.com/github/view_component test suite:
These warnings appear to be valid. The test suite does pass without these assignments.
It would be lovely if a release could be cut with these changes ❤️ Let me know if there's anything I can do to help!