Only pass template language to parser #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainbeeston
force-pushed
the
patch-1
branch
from
b846f03
to
3aefbad
Compare
|
I have signed the CLA! |
`assert_erb_safety` accepts a `filename` option which prints the filename in the error message, which is invaluable for finding which file the error comes from (without this the error message just reports that there is an error in "(buffer)"). However, passing the filename right now throws an error: `ArgumentError: unknown keyword: :filename`, which comes about because `assert_erb_safety` passes all of it's own options to straight to `BetterHtml::Parser` and that doesn't support a `filename` option (in fact it only supports `template_language`). I've changed `assert_erb_safety` so that it only passes the `template_language` option through to `Parser`, which fixes the error and allows `assert_erb_safety` to correctly include the filename in the assertion message.
|
Thanks @rafaelfranca I've incorporated your feedback now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_erb_safetyaccepts afilenameoption which prints the filename in the error message, which is invaluable for finding which file the error comes from (without this the error message just reports that there is an error in "(buffer)"). However, passing the filename right now also throws an error:ArgumentError: unknown keyword: :filename, which comes about becauseassert_erb_safetypasses all of it's own options to straight toBetterHtml::Parserand that doesn't support afilenameoption (in fact it only supportstemplate_language).I've changed
assert_erb_safetyso that it only passes thetemplate_languageoption through toParser, which fixes the error and allowsassert_erb_safetyto correctly include the filename in the assertion message.