[Timber] add cart discounts #522
Conversation
| @@ -64,7 +64,8 @@ | |||
| "checkout": "Check Out", | |||
| "empty": "Your cart is currently empty.", | |||
| "continue_browsing_html": "Continue browsing <a href=\"/collections/all\">here</a>.", | |||
| "close_cart": "Close Cart" | |||
| "close_cart": "Close Cart", | |||
| "savings": "You're saving" | |||
There was a problem hiding this comment.
Should we add the price right in this string? Some other languages might prefer the price and then savings text?
There was a problem hiding this comment.
That makes a lot of sense to me; I would say this warrants a change.
matcaissy
force-pushed
the
timber-add-cart-discounts
branch
from
6152ae1
to
15fdc67
Compare
|
@NathanPJF squashed and updated with price in the locale strings. Mind another 👀 Thx :) |
|
🎩 |
|
When does the discount show up on the Cart page? I've tested adding a discount promo code on the checkout page, then navigating back to the cart page, but it nothing relating to the discount shows up. No discount title or discounted price. |
|
I have the same question. I'm not seeing the discount on the cart yet, how is it supposed to work? |
|
Just a guess. Since the #2953 link above goes to a 404 error page, I assume that it's a fix for a new feature on a private Github page. |
|
This pull request isn't related to discount codes as you know them. It is to support automated cart savings which are only available to Plus merchants who use Shopify Scripts: https://www.shopify.com/enterprise/98548614-introducing-shopify-scripts-checkout-api-a-giant-leap-forward-for-hosted-ecommerce. |
| vendor: cartItem.vendor | ||
| vendor: cartItem.vendor, | ||
| linePrice: Shopify.formatMoney(cartItem.line_price, settings.moneyFormat), | ||
| originalPrice: Shopify.formatMoney((cartItem.line_price + cartItem.total_discount), settings.moneyFormat), |
There was a problem hiding this comment.
Since this is talking about cartItem.line_price, this can be:
originalLinePrice: Shopify.formatMoney(cartItem.original_line_price, settings.moneyFormat)
Fix for https://github.com/Shopify/shopify-themes/issues/2953
@NathanPJF 👀 when you can, thanks :)
CC @carolineschnapp @cshold