This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Content style update #487
Merged
Content style update #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for #486
We In addition to going through content checklist here https://docs.shopify.com/themes/theme-development/theme-store-requirements/content-style-guide
The Shopify themes team also decided to try and steer away from using the word Ajax in the theme settings as it's not meaningful to most merchants. The new option is a dropdown for cart type
Drawer will trigger the ajax drawer, Page will disable ajax and redirect to /cart on form submission. Additionally, developers and designers are also encouraged to use Modal, Flipdown, or other design types in the dropdown as wish.
@virginiastart @cshold I don't think I missed anything, but a double check is always good.