[BFCL Chore] Quick fix change of decorators from @overrides to @override
#797
+63
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new model `openbmb/MiniCPM3-4B-FC` to the leaderboard. --------- Co-authored-by: Huanzhi (Hans) Mao <huanzhimao@gmail.com>
… CLI (ShishirPatil#795) This PR adds the support for the `bfcl generate` and `bfcl evaluate` command to take in multiple values for the `--model` and `--test-category` arguments. For example, ``` bfcl generate --model claude-3-5-sonnet-20241022-FC,gpt-4o-2024-08-06-FC --test-category parallel,multiple,exec_simple ``` --------- Co-authored-by: Huanzhi (Hans) Mao <huanzhimao@gmail.com>
ShishirPatil#796) This PR updates the decoding logic for DeepSeek-Coder handler to fix its performance issue in the irrelevance category. The irrelevance category metric we use is that, either the `decode_ast` should fail (error) or the decoded output is empty (eg, empty list or empty string). For the DeepSeek-Coder model, When it outputs a valid function call, the model response will be a list of dictionaries `[{func1:{param1:val1,...}},{func2:{param2:val2,...}}]`, so it's fine for `decode_ast` to just return it without any processing. However, when the output is a message (not valid function call), under the `_parse_query_response_prompting` logic, the model response will be that message string, and in the current `decode_ast` implementation, that string will just be treated as the decoded output, and it would fail both the metric for the irrelevance category, which is not ideal.
HuanzhiMao
changed the title
@overrides to @override
HuanzhiMao
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing decorators in oss handlers to stay consistent with trusted documentation https://github.com/mkorpela/overrides