[BFCL] Multi Turn Dataset Fix (Miss Func & Long Context) #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShishirPatil
approved these changes
Oct 31, 2024
HuanzhiMao
added a commit
that referenced
this pull request
Oct 31, 2024
This PR updates the question and ground truth for the `multi_turn_miss_param` category, since they are augmented from `multi_turn_base` and the fix for the base entries was finalized in #723. Following #719, #722, #723, #725 and #728, this is also part of the effort to thoroughly bug fix the multi turn categories. --------- Co-authored-by: Charlie Cheng-Jie Ji <55744150+CharlieJCJ@users.noreply.github.com> Co-authored-by: Fanjia-Yan <78303449+Fanjia-Yan@users.noreply.github.com> Co-authored-by: VishnuSuresh27 <112032533+VishnuSuresh27@users.noreply.github.com>
Fanjia-Yan
reviewed
Oct 31, 2024
VishnuSuresh27
pushed a commit
to VishnuSuresh27/gorilla
that referenced
this pull request
Nov 11, 2024
…l#728) This PR updates the question and ground truth for the `multi_turn_miss_func` and `multi_turn_long_context` accordingly, since they are augmented from `multi_turn_base` and the fix for the base entries was finalized in ShishirPatil#723. Following ShishirPatil#719, ShishirPatil#722, ShishirPatil#723 and ShishirPatil#725, this is also part of the effort to thoroughly bug fix the multi turn categories. There will be one more PR coming for the `multi_turn_miss_param` category fix. --------- Co-authored-by: Charlie Cheng-Jie Ji <55744150+CharlieJCJ@users.noreply.github.com> Co-authored-by: Fanjia-Yan <78303449+Fanjia-Yan@users.noreply.github.com> Co-authored-by: VishnuSuresh27 <112032533+VishnuSuresh27@users.noreply.github.com>
VishnuSuresh27
pushed a commit
to VishnuSuresh27/gorilla
that referenced
this pull request
Nov 11, 2024
This PR updates the question and ground truth for the `multi_turn_miss_param` category, since they are augmented from `multi_turn_base` and the fix for the base entries was finalized in ShishirPatil#723. Following ShishirPatil#719, ShishirPatil#722, ShishirPatil#723, ShishirPatil#725 and ShishirPatil#728, this is also part of the effort to thoroughly bug fix the multi turn categories. --------- Co-authored-by: Charlie Cheng-Jie Ji <55744150+CharlieJCJ@users.noreply.github.com> Co-authored-by: Fanjia-Yan <78303449+Fanjia-Yan@users.noreply.github.com> Co-authored-by: VishnuSuresh27 <112032533+VishnuSuresh27@users.noreply.github.com>
HuanzhiMao
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the question and ground truth for the
multi_turn_miss_funcandmulti_turn_long_contextaccordingly, since they are augmented frommulti_turn_baseand the fix for the base entries was finalized in #723.Following #719, #722, #723 and #725, this is also part of the effort to thoroughly bug fix the multi turn categories. There will be one more PR coming for the
multi_turn_miss_paramcategory fix.Co-authored-by: Charlie Cheng-Jie Ji 55744150+CharlieJCJ@users.noreply.github.com
Co-authored-by: Fanjia-Yan 78303449+Fanjia-Yan@users.noreply.github.com
Co-authored-by: VishnuSuresh27 112032533+VishnuSuresh27@users.noreply.github.com