Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL-v3] Multi-Turn Possible Answer Order Change #679

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Fanjia-Yan
Copy link
Collaborator

@Fanjia-Yan Fanjia-Yan commented Oct 10, 2024

This PR fix the possible answer misalignment for miss_func and composite. The dataset entry will encounter a question with no suitable function, resulting in model chatting and then the dataset will supplement the suitable function, resulting in a function call.

Previous:

[["cd(folder='workspace')", "ls(a=True)"], [], ["mv(source='log.txt',destination='archive')"], ["cd(folder='archive')", "grep(file_name='log.txt',pattern='Error')"], ["tail(file_name='log.txt',lines=20)"]]

Current:

[[], ["cd(folder='workspace')", "ls(a=True)"], ["mv(source='log.txt',destination='archive')"], ["cd(folder='archive')", "grep(file_name='log.txt',pattern='Error')"], ["tail(file_name='log.txt',lines=20)"]]

The empty list signifies that no function should be invoked. No function should be invoked one turn earlier when no relevant functions are found.

@HuanzhiMao HuanzhiMao added the BFCL-Dataset BFCL Dataset-Related Issue label Oct 10, 2024
@ShishirPatil ShishirPatil changed the title [BFCL] Multi-Turn Possible Answer Order Change [BFCL-v3] Multi-Turn Possible Answer Order Change Oct 15, 2024
Copy link
Collaborator

@CharlieJCJ CharlieJCJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@ShishirPatil ShishirPatil merged commit 68ef9ae into ShishirPatil:main Oct 15, 2024
@HuanzhiMao HuanzhiMao deleted the possible_answer_order branch October 15, 2024 06:42
ShishirPatil pushed a commit that referenced this pull request Oct 21, 2024
This PR updates the leaderboard to reflect the change in score due to
the following PR merge:

1. #660 
2. #661
3. #683
4. #679
5. #708 
6. #709
7. #701
8. #657 
9. #658 
10. #640 
11. #653
12. #642 
13. #696 
14. #667

Close #662.

Note: Some models (like `firefunction`, `functionary`,
`microsoft/phi`)are not included in this leaderboard update because we
don't have all the entries generated. We will add them back once we get
the full result generated.
VishnuSuresh27 pushed a commit to VishnuSuresh27/gorilla that referenced this pull request Nov 11, 2024
This PR fix the possible answer misalignment for `miss_func` and
`composite`. The dataset entry will encounter a question with no
suitable function, resulting in model chatting and then the dataset will
supplement the suitable function, resulting in a function call.

Previous:
```
[["cd(folder='workspace')", "ls(a=True)"], [], ["mv(source='log.txt',destination='archive')"], ["cd(folder='archive')", "grep(file_name='log.txt',pattern='Error')"], ["tail(file_name='log.txt',lines=20)"]]
```
Current:
```
[[], ["cd(folder='workspace')", "ls(a=True)"], ["mv(source='log.txt',destination='archive')"], ["cd(folder='archive')", "grep(file_name='log.txt',pattern='Error')"], ["tail(file_name='log.txt',lines=20)"]]
```

The empty list signifies that no function should be invoked. No function
should be invoked one turn earlier when no relevant functions are found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFCL-Dataset BFCL Dataset-Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants