Add a helper class to simplify the usage of the BatchedAbortSignals.
#1103
+61
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I got all of our usages with this? Ended up being fewer than I initially thought. Also, while searching for these usages, I've deleted a few unused states from the user's reducer.
tec27
requested changes
Oct 10, 2024
| export function getChatUserProfile( | ||
| channelId: SbChannelId, | ||
| targetId: SbUserId, | ||
| spec: RequestHandlingSpec<void>, | ||
| ): ThunkAction { | ||
| return abortableThunk(spec, async (dispatch, getStore) => { | ||
| const requestCoalescer = new RequestCoalescer() |
There was a problem hiding this comment.
This doesn't work, you're making a new coalescer for every request so it will coalesce nothing. It needs to be global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got all of our usages with this? Ended up being fewer than I initially thought.
Also, while searching for these usages, I've deleted a few unused states from the user's reducer.
Closes #1101