Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty modules. #932

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Remove empty modules. #932

merged 1 commit into from
Apr 12, 2020

Conversation

richardxia
Copy link
Member

My bugfix to eslint-plugin-import finally made it in the latest release, so I want to make use of it and detect a bunch of unused imports.

The first set of things I found I wasn't even really expecting, which is that we have some completely empty JavaScript files lying around. This PR deletes them (and fixes some code that was somehow importing one of them).

@richardxia
Copy link
Member Author

I'm going to just merge this in since I think it's a pretty safe change, as the empty files are clearly not actually being used.

@richardxia richardxia merged commit c3f05d0 into master Apr 12, 2020
@richardxia richardxia deleted the remove-empty-modules branch April 12, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant