Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8.2 #438

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Conversation

Fredthelead
Copy link

Updates the codebase utilizing Rector.

  • Fixed non-static calls to static methods
  • Declared undefined properties
  • Fixed bad string concatenation
  • Use consistent implode (bonus)

@Fredthelead Fredthelead changed the title Feature/php82 Support for PHP 8.2 Sep 19, 2024
@develart-projects
Copy link
Collaborator

develart-projects commented Sep 19, 2024

8.2 is not really supported, because some functions are enforcing strict type-ing, breaking the compatibility. I'm happy to merge and appreciate your work, but pls change back the description :) thanks.

@sreichel
Copy link

Mhh, lgtm.

@develart-projects develart-projects added bug Something isn't working to be released PR exists or in master, but not released yet labels Sep 19, 2024
@develart-projects develart-projects added this to the 1.24.1 milestone Sep 19, 2024
@develart-projects develart-projects merged commit 459a61f into Shardj:master Sep 19, 2024
1 of 8 checks passed
@Fredthelead Fredthelead deleted the feature/PHP82 branch September 20, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to be released PR exists or in master, but not released yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants