Increase Performance in unsetting rules in ACL #134
Conversation
unsetting a non-existing rule doesn't throw an error. In our Project this change improves loading time from 55 sec to 0.5 sec (14412 Resources, 11694 Rules)
|
@schrankenstein improve PR title/body. performance fix in what component? what's the test case? what's the downside of the change? is this backward compatible change? add unit test showing compatibility? |
schrankenstein
changed the title
|
@glensc The fix is to unset the rules about 100times faster than the "old" way. The PR is already merged into zf2 (zendframework/zend-permissions-acl#29) and laminas (https://github.com/laminas/laminas-permissions-acl/blob/1ad5f2c7d65b4c2a4395010c285d583f22f9c373/src/Acl.php#L404). You can test this everytime you have changes to the acl leading to a remove of all rules by calling removeResourceAll(). The unset is very slow if you unset the roles with comparing every single existing role. There is absolutely no need for this. You can directly unsetting them without the nested foreach. Our test case is a page with many resources and rules as mentioned above. We tested this on PHP >= 5.6, the travis-ci build of zf2 is passed (see https://travis-ci.org/github/zendframework/zend-permissions-acl/builds/373529251). I did my best to describe this, i hope this is a bit clearer now |
schrankenstein
changed the title
unsetting a non-existing rule doesn't throw an error. In our Project this change improves loading time from 55 sec to 0.5 sec (14412 Resources, 11694 Rules) Refs: - Shardj/zf1-future#134 - zendframework/zend-permissions-acl#29 - zendframework/zf1#737 Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
unsetting a non-existing rule doesn't throw an error. In our Project this change improves loading time from 55 sec to 0.5 sec (14412 Resources, 11694 Rules) Refs: - Shardj/zf1-future#134 - zendframework/zend-permissions-acl#29 - zendframework/zf1#737 Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
unsetting a non-existing rule doesn't throw an error.
In our Project this change improves loading time from 55 sec to 0.5 sec
(14412 Resources, 11694 Rules)
(see zendframework#737)