Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated : Return type on Zend_Session_SaveHandler_DbTable #377

Closed
fanlei opened this issue Sep 10, 2023 · 5 comments
Closed

Deprecated : Return type on Zend_Session_SaveHandler_DbTable #377

fanlei opened this issue Sep 10, 2023 · 5 comments
Assignees
Labels
to be released PR exists or in master, but not released yet
Milestone

Comments

@fanlei
Copy link

fanlei commented Sep 10, 2023

I upgraded PHP to 8.1 and got the following "Deprecated" message. Any suggestions to handle them? Thanks in advance!

Deprecated: Return type of Zend_Session_SaveHandler_DbTable::open($save_path, $name) should either be compatible with SessionHandlerInterface::open(string $path, string $name): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in
/vagrant/dealerdirect/vendor/shardj/zf1-future/library/Zend/Session/SaveHandler/DbTable.php
on line 293
Deprecated: Return type of Zend_Session_SaveHandler_DbTable::close() should either be compatible with SessionHandlerInterface::close(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in
/vagrant/dealerdirect/vendor/shardj/zf1-future/library/Zend/Session/SaveHandler/DbTable.php
on line 306
Deprecated: Return type of Zend_Session_SaveHandler_DbTable::read($id) should either be compatible with SessionHandlerInterface::read(string $id): string|false, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in
/vagrant/dealerdirect/vendor/shardj/zf1-future/library/Zend/Session/SaveHandler/DbTable.php
on line 317
Deprecated: Return type of Zend_Session_SaveHandler_DbTable::write($id, $data) should either be compatible with SessionHandlerInterface::write(string $id, string $data): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in
/vagrant/dealerdirect/vendor/shardj/zf1-future/library/Zend/Session/SaveHandler/DbTable.php
on line 341
Deprecated: Return type of Zend_Session_SaveHandler_DbTable::destroy($id) should either be compatible with SessionHandlerInterface::destroy(string $id): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in
/vagrant/dealerdirect/vendor/shardj/zf1-future/library/Zend/Session/SaveHandler/DbTable.php
on line369
Deprecated : Return type of Zend_Session_SaveHandler_DbTable::gc($maxlifetime) should either be compatible with SessionHandlerInterface::gc(int $max_lifetime): int|false, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in
/vagrant/dealerdirect/vendor/shardj/zf1-future/library/Zend/Session/SaveHandler/DbTable.php
on line 381
@develart-projects
Copy link
Collaborator

It's because of this change: #357

Feel free to open PR to revert it, I'll merge it, thanks.

@fanlei
Copy link
Author

fanlei commented Sep 13, 2023

@develart-projects Thanks for the information! Looks like there were some thoughts for #357
Instead of reverting it, I just added the #[\ReturnTypeWillChange] to Zend_Session_SaveHandler_DbTable to avoid the notice. PR is #379

fanlei added a commit to fanlei/zf1-future that referenced this issue Sep 13, 2023
develart-projects added a commit that referenced this issue Sep 13, 2023
…ecated

Fixed #357 return type backward-compatible issue reported at #377
@develart-projects develart-projects added this to the 1.24.0 milestone Sep 13, 2023
@develart-projects develart-projects added the to be released PR exists or in master, but not released yet label Sep 13, 2023
@WebTigers
Copy link
Sponsor

Has this been resolved? When is this issue going to get resolved for PHP8.1?

@fanlei
Copy link
Author

fanlei commented Dec 1, 2023

Has this been resolved? When is this issue going to get resolved for PHP8.1?

It is supposed to be included in 1.24.0, which has not been released at this point.

@develart-projects
Copy link
Collaborator

Very soon :) need to revive some doc files, that's the showstopper. will do release right after. Hopefully in coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be released PR exists or in master, but not released yet
Projects
None yet
Development

No branches or pull requests

3 participants