Skip to content

Commit

Permalink
fix: Deprecation Notice Class does not comply with psr-0 autoloading …
Browse files Browse the repository at this point in the history 
…standard. It will not autoload anymore in Composer v2.0.
  • Loading branch information
@Jimbolino
Jimbolino committed Apr 29, 2020
1 parent 1a3d78e commit d822ef1
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 1 deletion.
0 ...y/Zend/Application/Resource/Useragent.php → ...y/Zend/Application/Resource/UserAgent.php
View file
File renamed without changes.
0 ...y/Zend/Gdata/Analytics/Extension/Goal.php → library/Zend/Gdata/Analytics/Goal.php
View file
File renamed without changes.
0 ...amework/Provider/DocblockManifestable.php → ...rk/Provider/DocblockManifestInterface.php
View file
File renamed without changes.
0 ...Zend/Validate/Barcode/Intelligentmail.php → ...Zend/Validate/Barcode/IntelligentMail.php
View file
File renamed without changes.
2 changes: 1 addition & 1 deletion tests/Zend/Application/Resource/UseragentTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
*/
require_once 'Zend/Loader/Autoloader.php';
require_once 'Zend/Application/Resource/ResourceAbstract.php';
require_once 'Zend/Application/Resource/Useragent.php';
require_once 'Zend/Application/Resource/UserAgent.php';

/**
* @category Zend
Expand Down

5 comments on commit d822ef1

@kstenschke
Copy link

@kstenschke kstenschke commented on d822ef1 Jul 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jimbolino
see also #92
It seems like this change causes a bootstrap error: Unable to resolve plugin "useragent"; no corresponding plugin with that name (when using composer < 2?)

  • Is this change supposed to be downwards-compatible to work also with composer < 2 (version 2 is still alpha ATM)?
  • Is there a related configuration (maybe adding shardj/zf1-future/library to include-path of composer.json?) that must be added to make applications using the Useragent plugin continue to work after this change?

As some users will probably freeze zf1-future at version 1.17.2 when not receiving any info on this, It would be helpful if there are configuration changes needed after this diff, to document those within https://github.com/Shardj/zf1-future/blob/master/README.md.

@Drivez
Copy link

@Drivez Drivez commented on d822ef1 Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was having the same issue with Unable to resolve plugin "useragent"; no corresponding plugin with that name, I think we will freeze it on 1.17.2 version

@Jimbolino
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please give me some code to reproduce, so i can fix it :)

@kstenschke
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test the latest patch yet (am on holidays). The issue occurs on a rather large non-open source project, which i cannot publish. I'll have to see if i can pinpoint the issue and let you know. Thank you for willing to help.

@Drivez
Copy link

@Drivez Drivez commented on d822ef1 Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jimbolino I updated issue #92

Please sign in to comment.