Merge pull request #373 from develart-projects/sendmailTransportWrong…

…Coparsion Sendmail transport - wrong comparison fix
Shardj · Aug 24, 2023 · 622a60b · 622a60b
2 parents 61cf50b + 97b188e
commit 622a60b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.23.4] - 2023-08-24
+### Fixed
+- corrected Zend Mail sendmail transport comparison
+
 ## [1.23.3] - 2023-08-23
 ### Added
 - Enabled testing of APCU for all PHP versions when running with all extensions enabled by @boenrobot in https://github.com/Shardj/zf1-future/pull/363

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "shardj/zf1-future",
     "description": "Zend Framework 1. The aim is to keep ZF1 working with the latest PHP versions",
     "type": "library",
-    "version": "1.23.3",
+    "version": "1.23.4",
     "keywords": [
         "framework",
         "zf1"

diff --git a/library/Zend/Mail/Transport/Sendmail.php b/library/Zend/Mail/Transport/Sendmail.php
@@ -138,7 +138,7 @@ public function _sendMail()
             // Sanitize the From header
             // https://github.com/Shardj/zf1-future/issues/326
 
-            if ( empty($fromEmailHeader) === FALSE ) { // nothing to worry about
+            if ( empty($fromEmailHeader) === TRUE ) { // nothing to worry about
                 goto processMail;
             }
 

diff --git a/library/Zend/Version.php b/library/Zend/Version.php
@@ -32,7 +32,7 @@ final class Zend_Version
     /**
      * Zend Framework version identification - see compareVersion()
      */
-    const VERSION = '1.23.3';
+    const VERSION = '1.23.4';
 
     /**
      * The latest stable version Zend Framework available