Add support for 127.0.0.1 alongside localhost when getting relative URLs #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JackBailey Thanks for the update! Looks good to me. |
truecharts-admin
referenced
this pull request
in truecharts/public
May 5, 2024
…6afb83f by renovate (#21593) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [shaneisrael/fireshare](https://togithub.com/ShaneIsrael/fireshare) | patch | `v1.2.19` -> `v1.2.20` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ShaneIsrael/fireshare (shaneisrael/fireshare)</summary> ### [`v1.2.20`](https://togithub.com/ShaneIsrael/fireshare/releases/tag/v1.2.20) [Compare Source](https://togithub.com/ShaneIsrael/fireshare/compare/v1.2.19...v1.2.20) #### What's Changed - Add support for 127.0.0.1 alongside localhost when getting relative URLs by [@​JackBailey](https://togithub.com/JackBailey) in [https://github.com/ShaneIsrael/fireshare/pull/248](https://togithub.com/ShaneIsrael/fireshare/pull/248) - Update greenlet version for Python 3.11+ support by [@​JackBailey](https://togithub.com/JackBailey) in [https://github.com/ShaneIsrael/fireshare/pull/247](https://togithub.com/ShaneIsrael/fireshare/pull/247) - Update docker-compose.yml by [@​ShaneIsrael](https://togithub.com/ShaneIsrael) in [https://github.com/ShaneIsrael/fireshare/pull/251](https://togithub.com/ShaneIsrael/fireshare/pull/251) - Disable nginx sendfile by [@​ShaneIsrael](https://togithub.com/ShaneIsrael) in [https://github.com/ShaneIsrael/fireshare/pull/255](https://togithub.com/ShaneIsrael/fireshare/pull/255) #### New Contributors - [@​JackBailey](https://togithub.com/JackBailey) made their first contribution in [https://github.com/ShaneIsrael/fireshare/pull/248](https://togithub.com/ShaneIsrael/fireshare/pull/248) **Full Changelog**: ShaneIsrael/fireshare@v1.2.19...v1.2.20 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM0MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, fireshare handles localhost specially, allowing for local development, however, 127.0.0.1 is not included in this.
This PR adds a isLocalhost variable allowing both 127.0.0.1 and localhost to make use of this functionality. I could use localhost but macOS seems to have some issues with that.
I'm also adding HLS support in #249