Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base_url on android thumbnail #72

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

edestecd
Copy link
Contributor

Thumbnails stopped working for me on Android recently and this fixed it

Thumbnails stopped working for me on Android recently and this fixed it
@edestecd
Copy link
Contributor Author

edestecd commented Aug 12, 2023

I'm not sure but it may have something to do with enabling https recently. That or an Android update...

@SgtBatten
Copy link
Owner

I'm not sure but it may have something to do with enabling https recently. That or an Android update...

Could you please explain what you mean. Did HA do something or did you do something?

@edestecd
Copy link
Contributor Author

I put a reverse proxy in front of frigate with https. Caddy specifically. B/c of https all the way through absolute urls are required. This should not break http, but feel free to test.

@SgtBatten
Copy link
Owner

I also have reverse proxies on all my services. Via nginx through swag.

However they are not used internally. So when configuring the home assistant frigate integration I still just use the http Lan IP and port. Did you use something else there?

@edestecd
Copy link
Contributor Author

I use https internally as well as I have multiple locations with frigate and although I'm using a vpn its still not on the same box so I prefer to use https everywhere.

@edestecd
Copy link
Contributor Author

In other words when configuring the home assistant integration I go through the proxy and use https. Everything else works as it should except this so I went investigating and this fixed it.

@edestecd
Copy link
Contributor Author

Can you verify this change continues to work in your setup? If so then we have a config that works for both and I think its good for all

@SgtBatten
Copy link
Owner

Adding baseurl would work for all. I'm unsure if it introduces inefficiencies in delivery of images and videos though

@SgtBatten SgtBatten merged commit 2312e52 into SgtBatten:main Aug 24, 2023
@edestecd edestecd deleted the edestecd-patch-1 branch July 8, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants