Support new sub_label format from Frigate #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0.13.0-beta the structure of the sub_label changed to include a person name AND score. Could be improved to better test for null values, or support both versions of the field at the same time. Tested against Frigate 0.13.0-beta5 and DoubleTake 1.13.11.8 (fork https://github.com/skrashevich/double-take/)
|
Thanks very much. It looks good. I'll test it next week. Really appreciate it. |
|
Cool. I tried to make it detect which format of sublabel was being used but failed. Need something like isarray(). I also noted to the frigate project discussion that it should really be JSON not an array. Maybe next release but not 0.13. |
SgtBatten
previously approved these changes
Nov 30, 2023
SgtBatten
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.13.0-beta the structure of the sub_label changed to include a person name AND score.
Could be improved to better test for null values, or support both versions of the field at the same time.
Tested against Frigate 0.13.0-beta5 and DoubleTake 1.13.11.8 (fork https://github.com/skrashevich/double-take/)