Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify gift card configuration factory #224

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

loevgaard
Copy link
Member

No description provided.

@loevgaard loevgaard requested a review from Roshyo May 9, 2022 06:51
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #224 (621ec85) into 0.12.x (b0c74a5) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 621ec85 differs from pull request most recent head 7e09d62. Consider uploading reports for the commit 7e09d62 to get more accurate results

@@             Coverage Diff              @@
##             0.12.x     #224      +/-   ##
============================================
- Coverage     50.32%   50.23%   -0.09%     
  Complexity      532      532              
============================================
  Files           102      102              
  Lines          1699     1696       -3     
============================================
- Hits            855      852       -3     
  Misses          844      844              
Impacted Files Coverage Δ
src/Factory/GiftCardConfigurationFactory.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c74a5...7e09d62. Read the comment docs.

@loevgaard loevgaard merged commit d4a716c into 0.12.x May 9, 2022
@loevgaard loevgaard deleted the simplify-factory branch May 9, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants