Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GiftCardConfigurationProvider always return GiftCardConfiguration #221

Merged
merged 1 commit into from
May 9, 2022

Conversation

loevgaard
Copy link
Member

Fixes #220

I think this PR makes a lot of sense given the name of the provider. You expect the GiftCardConfigurationProvider to actually provide a GiftCardConfiguration.

@loevgaard loevgaard requested a review from Roshyo May 6, 2022 12:59
@loevgaard loevgaard force-pushed the 220-gift-card-configuration-provider branch 2 times, most recently from f0cd8b8 to 6fc1dbc Compare May 6, 2022 13:23
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #221 (e8d3bfd) into 0.12.x (d4a716c) will decrease coverage by 0.70%.
The diff coverage is 19.29%.

❗ Current head e8d3bfd differs from pull request most recent head 9d1a5f4. Consider uploading reports for the commit 9d1a5f4 to get more accurate results

@@             Coverage Diff              @@
##             0.12.x     #221      +/-   ##
============================================
- Coverage     50.23%   49.53%   -0.71%     
- Complexity      532      534       +2     
============================================
  Files           102      103       +1     
  Lines          1696     1716      +20     
============================================
- Hits            852      850       -2     
- Misses          844      866      +22     
Impacted Files Coverage Δ
...pi/Controller/Action/DownloadGiftCardPdfAction.php 87.50% <ø> (-12.50%) ⬇️
...rc/Controller/Action/DownloadGiftCardPdfAction.php 0.00% <ø> (ø)
...c/Doctrine/ORM/GiftCardConfigurationRepository.php 0.00% <0.00%> (ø)
src/Provider/GiftCardConfigurationProvider.php 0.00% <0.00%> (ø)
src/DependencyInjection/Configuration.php 100.00% <100.00%> (ø)
src/Factory/GiftCardFactory.php 100.00% <100.00%> (ø)
src/Model/GiftCardChannelConfiguration.php 73.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a716c...9d1a5f4. Read the comment docs.

@loevgaard loevgaard force-pushed the 220-gift-card-configuration-provider branch from 6fc1dbc to dbf0293 Compare May 6, 2022 13:30
Copy link
Contributor

@Roshyo Roshyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, it will ease the work to configure the plugin

@loevgaard loevgaard force-pushed the 220-gift-card-configuration-provider branch from dbf0293 to 9d1a5f4 Compare May 9, 2022 07:03
@loevgaard loevgaard merged commit 4dda806 into 0.12.x May 9, 2022
@loevgaard loevgaard deleted the 220-gift-card-configuration-provider branch May 9, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants