Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow preventing sending the notification email on GC creation #219

Merged
merged 9 commits into from
May 9, 2022

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented May 6, 2022

Fixes #205

image

image

@Roshyo Roshyo requested a review from loevgaard May 6, 2022 07:05
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #219 (7ec1891) into 0.12.x (5ae31ba) will increase coverage by 0.59%.
The diff coverage is 21.42%.

@@             Coverage Diff              @@
##             0.12.x     #219      +/-   ##
============================================
+ Coverage     49.73%   50.32%   +0.59%     
- Complexity      528      532       +4     
============================================
  Files           102      102              
  Lines          1687     1699      +12     
============================================
+ Hits            839      855      +16     
+ Misses          848      844       -4     
Impacted Files Coverage Δ
src/Form/Type/GiftCardType.php 0.00% <0.00%> (ø)
...ener/SendEmailWithGiftCardToCustomerSubscriber.php 85.71% <100.00%> (+85.71%) ⬆️
src/Model/GiftCard.php 75.45% <100.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae31ba...7ec1891. Read the comment docs.

@Roshyo Roshyo requested a review from loevgaard May 6, 2022 08:33
@Roshyo Roshyo force-pushed the allow-preventing-sending-notification branch from 997bcd6 to 6960fbe Compare May 6, 2022 08:36
@loevgaard
Copy link
Member

I think what this PR is missing is the case where an administrator updates a gift card, but doesn't change the email, then the user would get an email notification again.

This could easily be solved, I think, by just having the sendNotificationEmail property to be false by default

@Roshyo Roshyo merged commit b0c74a5 into 0.12.x May 9, 2022
@Roshyo Roshyo deleted the allow-preventing-sending-notification branch May 9, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants